-
Notifications
You must be signed in to change notification settings - Fork 40
Convert CLI code to TypeScript #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harmony7
wants to merge
12
commits into
main
Choose a base branch
from
kats/typescript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like a lot of build errors: https://github.com/fastly/js-compute-runtime/actions/runs/20024236031/job/57417839369?pr=1247 |
Member
Author
|
Thanks my bad I missed a step when updating the workflow files. I'll go check them out and fix them |
e4231a3 to
0925ef9
Compare
807e0dd to
10e67b9
Compare
10e67b9 to
563bff8
Compare
TartanLlama
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the JavaScript source code in the CLI to TypeScript.
.eslintrc.cjstoeslint.config.mjs./src/rsrc/were used as resource files during the build and have been moved to/rsrc..jssource files in/srcare migrated in place to.tsjs-compute-runtime-cli.js, has been moved to/src/cli/js-compute-runtime-cli.js/srcto/dist- this is a newbuild:clistep that is run as part ofnpm run buildand had been added to CI./js-compute-runtime-cli.jshave been updated to/dist/cli/js-compute-runtime-cli.js, includingpackage.jsonand a few testsThe goal of this is for type safety and maintainability, including ease of adding new features.
I've tested that all related tests pass and that the updated package is usable with my projects locally.
I've added
LicenseRef-scancode-unicode AND MITas an allowed license combination pair (needed fortypescript, which is a dev dependency)