Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute build): Emit warning if Rust 1.82.0 (or higher) are used for the build. #1327

Closed
wants to merge 2 commits into from

Conversation

kpfleming
Copy link
Contributor

@kpfleming kpfleming commented Oct 18, 2024

Rust 1.82.0 introduced a change to how 'reference types' are handled in WebAssembly and the Compute platform is not yet compatible with that change.

@kpfleming kpfleming changed the title fix(compute build): Emit warning if Rust 1.82.0 (or higher) are used … fix(compute build): Emit warning if Rust 1.82.0 (or higher) are used for the build. Oct 18, 2024
@kpfleming kpfleming requested a review from Integralist October 18, 2024 12:43
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to bump the config_version so as to ensure existing users (who already have a local config) will have this changed merged into their existing config.

See https://github.com/fastly/cli/blob/main/DEVELOPMENT.md#fastlyconfigtoml

If the config has changed in any way, then you (the CLI developer) should ensure the config_version number is bumped before publishing a new CLI release. This is because when the user updates to that new CLI version and the invoke the CLI, the CLI will identify a mismatch between the user's local config version and the embedded config version. This will cause the embedded config to be merged with the local config and consequently the user's config will be updated to include the new fields.

@kpfleming
Copy link
Contributor Author

In my local testing, without bumping config_version, the config.toml file was updated to have the new toolchain_constraint value. I'm not able to track down the code path which caused this at the moment as I have to head to the airport, but I'd prefer not to bump config_version if it's not necessary and it does not seem to be necessary.

@kpfleming
Copy link
Contributor Author

I'm closing this PR as it will not be necessary; the Compute fleet is being updated to be compatible with WASM packages produced by Rust 1.82 and that should be complete within the next few days.

@kpfleming kpfleming closed this Oct 19, 2024
@kpfleming kpfleming deleted the rust-1.82-warning branch October 19, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants