Skip to content

Commit

Permalink
Fix command substitution issue for Windows OS. (#677)
Browse files Browse the repository at this point in the history
* fix windows script build

* update node version

* update README to reference CHANGELOG
  • Loading branch information
Integralist authored Oct 18, 2022
1 parent 631b290 commit ef89572
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
matrix:
tinygo-version: [0.24.0]
go-version: [1.18.x]
node-version: [12]
node-version: [18]
rust-toolchain: [stable]
platform: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.platform }}
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ using the bug report template.

[bug]: https://github.com/fastly/cli/issues/new?labels=bug&template=bug_report.md

Please also check the [CHANGELOG](./CHANGELOG.md) for any breaking-changes or migration guidance.

### Security issues

Please see our [SECURITY.md](SECURITY.md) for guidance on reporting security-related issues.
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/compute/language_javascript.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const JsCompilationURL = "https://www.npmjs.com/package/@fastly/js-compute"
// are simply upgrading their CLI version and might not be familiar with the
// changes in the 4.0.0 release with regards to how build logic has moved to the
// fastly.toml manifest.
const JsDefaultBuildCommand = "$(npm bin)/webpack && $(npm bin)/js-compute-runtime ./bin/index.js ./bin/main.wasm"
const JsDefaultBuildCommand = "npm exec webpack && npm exec js-compute-runtime ./bin/index.js ./bin/main.wasm"

// JsInstaller is the command used to install the dependencies defined within
// the Js language manifest.
Expand Down

0 comments on commit ef89572

Please sign in to comment.