Skip to content

Conversation

@g12i
Copy link
Contributor

@g12i g12i commented Jan 17, 2025

undici accepts any kind of Dispatcher, however this was not reflected in types

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd for types.

@g12i
Copy link
Contributor Author

g12i commented Jan 23, 2025

Hello @mcollina, sure added in 9ce5f66

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g12i
Copy link
Contributor Author

g12i commented Jan 27, 2025

Nice, thank you @mcollina @gurgunday @dancastillo. I don't have rights to merge this so I leave it up to you.

@g12i
Copy link
Contributor Author

g12i commented Feb 3, 2025

👋

@mcollina mcollina merged commit 1756f98 into fastify:main Feb 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants