fastifyCookieClearCookie sets maxAge to zero

fastify · Oct 9, 2024 · c3e98d8 · c3e98d8
1 parent f2aed09
commit c3e98d8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@fastify/cookie",
-  "version": "10.0.1",
+  "version": "10.0.2",
   "description": "Plugin for fastify to add support for cookies",
   "main": "plugin.js",
   "type": "commonjs",

diff --git a/plugin.js b/plugin.js
@@ -42,7 +42,7 @@ function fastifyCookieClearCookie (reply, name, options) {
   const opts = Object.assign({ path: '/' }, options, {
     expires: new Date(1),
     signed: undefined,
-    maxAge: undefined
+    maxAge: 0
   })
 
   return fastifyCookieSetCookie(reply, name, '', opts)

diff --git a/test/cookie.test.js b/test/cookie.test.js
@@ -224,7 +224,7 @@ test('share options for setCookie and clearCookie', (t) => {
     t.equal(cookies.length, 1)
     t.equal(cookies[0].name, 'foo')
     t.equal(cookies[0].value, '')
-    t.equal(cookies[0].maxAge, undefined)
+    t.equal(cookies[0].maxAge, 0)
 
     t.ok(new Date(cookies[0].expires) < new Date())
   })
@@ -1054,7 +1054,7 @@ test('clearCookie should include parseOptions', (t) => {
     t.equal(cookies.length, 1)
     t.equal(cookies[0].name, 'foo')
     t.equal(cookies[0].value, '')
-    t.equal(cookies[0].maxAge, undefined)
+    t.equal(cookies[0].maxAge, 0)
     t.equal(cookies[0].path, '/test')
     t.equal(cookies[0].domain, 'example.com')