feat: Add dependency resolution logic for plugins#179
Draft
feat: Add dependency resolution logic for plugins#179
Conversation
Member
Author
|
want to improve the types of it |
gurgunday
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds dependency resolution logic for plugins by introducing a resolveDependencyFromApp function that allows plugins to resolve dependencies from the Fastify application's DI container.
- Added
resolveDependencyFromApphelper function to resolve dependencies from the app's DI container - Included test coverage for the new dependency resolution functionality
- Updated documentation with usage examples for plugin dependency injection
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/fastifyAwilixPlugin.js | Adds the resolveDependencyFromApp helper function and exports it |
| test/fastifyAwilixPlugin.test.js | Adds test coverage for the new dependency resolution functionality |
| README.md | Documents the new plugin dependency resolution feature with examples |
| For this purpose there is a helper class available in `@fastify/awilix`: | ||
|
|
||
| ```ts | ||
| import { FastifyDependencyProvider } from '@fastify/awilix' |
There was a problem hiding this comment.
The import statement references FastifyDependencyProvider but the actual exported function is resolveDependencyFromApp. The import should be import { resolveDependencyFromApp } from '@fastify/awilix'.
Suggested change
| import { FastifyDependencyProvider } from '@fastify/awilix' | |
| import { resolveDependencyFromApp } from '@fastify/awilix' |
Co-authored-by: Copilot <[email protected]> Signed-off-by: Frazer Smith <[email protected]>
Fdawgs
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct