feat: Add support for custom Inno Setup 6 installation path #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for configuring a custom Inno Setup 6 installation path when building Windows
.exepackages, addressing issue #244.Previously, the path was hardcoded to
C:\Program Files (x86)\Inno Setup 6, which caused issues for users who:Changes
Core Implementation
inno_setup_pathoptional field toMakeExeConfigclassInnoSetupCompiler.compile()to accept a custom path parameterAppPackageMakerExeto pass the custom path from configurationDocumentation
Testing
Usage
Users can now specify a custom Inno Setup installation path in their
windows/packaging/exe/make_config.yaml:Backward Compatibility
This change is fully backward compatible. Existing configurations will continue to work unchanged, automatically using the default path
C:\Program Files (x86)\Inno Setup 6.Error Handling
Improved error messages now show the actual path being checked when Inno Setup is not found, making troubleshooting easier for users.
Closes #244
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)https://storage.googleapis.com/flutter_infra_release/flutter/a8bfdfc394deaed5c57bd45a64ac4294dc976a72/dart-sdk-linux-x64.zipcurl --retry 3 --continue-at - --location --output /tmp/flutter/bin/cache/dart-sdk-linux-x64.zip REDACTED(http block)https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.24.3-stable.tar.xzcurl -fsSL REDACTED -o flutter.tar.xz(http block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.