Skip to content

✅ Fix incorrect mocking in unit tests (issue #1780) #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

✅ Fix incorrect mocking in unit tests (issue #1780) #1781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5321f5b
Fix broken unit tests
vicaya Aug 20, 2025
b398d7c
Merge remote-tracking branch 'upstream/master' into fix_backend_init_…
YuriiMotov Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions backend/tests/scripts/test_backend_pre_start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@ def test_init_successful_connection() -> None:
engine_mock = MagicMock()

session_mock = MagicMock()
exec_mock = MagicMock(return_value=True)
session_mock.configure_mock(**{"exec.return_value": exec_mock})
session_mock.__enter__.return_value = session_mock

select1 = select(1)

with (
patch("sqlmodel.Session", return_value=session_mock),
patch("app.backend_pre_start.Session", return_value=session_mock),
patch("app.backend_pre_start.select", return_value=select1),
patch.object(logger, "info"),
patch.object(logger, "error"),
patch.object(logger, "warn"),
Expand All @@ -28,6 +30,4 @@ def test_init_successful_connection() -> None:
connection_successful
), "The database connection should be successful and not raise an exception."

assert session_mock.exec.called_once_with(
select(1)
), "The session should execute a select statement once."
session_mock.exec.assert_called_once_with(select1)
12 changes: 6 additions & 6 deletions backend/tests/scripts/test_test_pre_start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@ def test_init_successful_connection() -> None:
engine_mock = MagicMock()

session_mock = MagicMock()
exec_mock = MagicMock(return_value=True)
session_mock.configure_mock(**{"exec.return_value": exec_mock})
session_mock.__enter__.return_value = session_mock

select1 = select(1)

with (
patch("sqlmodel.Session", return_value=session_mock),
patch("app.tests_pre_start.Session", return_value=session_mock),
patch("app.tests_pre_start.select", return_value=select1),
patch.object(logger, "info"),
patch.object(logger, "error"),
patch.object(logger, "warn"),
Expand All @@ -28,6 +30,4 @@ def test_init_successful_connection() -> None:
connection_successful
), "The database connection should be successful and not raise an exception."

assert session_mock.exec.called_once_with(
select(1)
), "The session should execute a select statement once."
session_mock.exec.assert_called_once_with(select1)