fix(claude-plugin): sync current provider config to settings.json#1905
Open
chengww5217 wants to merge 1 commit intofarion1231:mainfrom
Open
fix(claude-plugin): sync current provider config to settings.json#1905chengww5217 wants to merge 1 commit intofarion1231:mainfrom
chengww5217 wants to merge 1 commit intofarion1231:mainfrom
Conversation
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Owner
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5bf24ae97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chengww5217
force-pushed
the
fix/enable-claude-plugin-integration-sync
branch
from
c5bf24a to
13110a2
Compare
…toggle enable - Extract syncClaudePluginIfChanged to share logic between autoSaveSettings and saveSettings - Fix P1: enableClaudePluginIntegration toggle in General tab now actually syncs ~/.claude/settings.json - Fix P2: check syncCurrentProvidersLiveSafe() return value and show toast on failure - Fix P3: sync providers on both enable and disable, not just enable - Fix P4: avoid double syncCurrentProvidersLiveSafe when plugin toggle + dir change happen together - Remove duplicate comment - Add missing providersApi.getCurrent/getAll mocks in tests
chengww5217
force-pushed
the
fix/enable-claude-plugin-integration-sync
branch
from
13110a2 to
b994f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
When enabling the "Apply to Claude Code extension" toggle (
enableClaudePluginIntegration), the app only wroteprimaryApiKeyto~/.claude/config.jsonbut never synced the current provider's full config (apiKey, apiBaseUrl, etc.) to~/.claude/settings.json. This caused the VS Code Claude Code extension to fail to connect, especially for first-time users.This PR fixes the issue by:
officialor not) instead of hardcodingofficial: falsesyncCurrentProvidersLiveSafe()to write the current provider's full config to~/.claude/settings.jsonwhen the toggle is enabledRelated Issue / 关联 Issue
Fixes #1904
Screenshots / 截图
settings.jsonempty, extension cannot connectsettings.jsonsynced with current provider config immediatelyChecklist / 检查清单
pnpm typecheckpasses / 通过 TypeScript 类型检查pnpm format:checkpasses / 通过代码格式检查cargo clippypasses (if Rust code changed) / 通过 Clippy 检查（如修改了 Rust 代码）N/A, no Rust code changed
N/A, no user-facing text changed