fix: python versions < 3.4 broken by previous addition #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My addition of quicker checking for python unittest modules breaks python verison less than 3.4. `importlib.machinery.PathFinder` was added in python 3.4 and will fail to import in verions prior to this. This changes the code to only use the new check if the python version is greater than or equal to 3.4. Note that `sys.version_info` was added in version 2.0; unittest was added in python 2.1; older versions of pytest support as low as python 2.7, so this change should be safe for any python version supporting unit testing.
fannheyward
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred to me late last night that my previous PR broke older python versions, here's a fix for that
My addition of quicker checking for python unittest modules breaks python version less than 3.4.
importlib.machinery.PathFinderwas added in python 3.4 and will fail to import in versions prior to this.This changes the code to only use the new check if the python version is greater than or equal to 3.4. Note that
sys.version_infowas added in version 2.0; unittest was added in python 2.1; older versions of pytest support as low as python 2.7, so this change should be safe for any python version supporting unit testing.