Skip to content

fix(http): relax CORP to cross-origin so allow-listed clients can load resources #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dev-fani merged 2 commits into from
Aug 30, 2026
Merged

fix(http): relax CORP to cross-origin so allow-listed clients can load resources #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a317cdc
fix(http): relax CORP to cross-origin so allow-listed clients can loa…
Sundriveauto Aug 30, 2026
8e4b2d0
Merge branch 'main' into fix/cross-origin-resource-policy
Sundriveauto Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/shared/http/plugins/security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ export default fp(async function securityPlugin(app: FastifyInstance) {
objectSrc: ["'none'"],
},
},
// Helmet's default is `same-origin`, which is enforced by browsers
// independently of CORS: it blocks allow-listed cross-origin clients
// from loading this API's responses at all via a no-CORS-mode request
// (e.g. displaying an uploaded evidence image with `<img src=...>`).
// Since CORS_ORIGIN already allow-lists the cooperating client origins,
// relax CORP to let those resources load — `same-origin` would silently
// break them regardless of the CORS configuration.
crossOriginResourcePolicy: { policy: 'cross-origin' },
});

await app.register(cors, {
Expand Down
Loading