Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tvdb indexer #899

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

feat: add tvdb indexer #899

wants to merge 29 commits into from

Conversation

TOomaAh
Copy link
Contributor

@TOomaAh TOomaAh commented Jul 26, 2024

Description

Screenshot (if UI-related)

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

@fallenbagel fallenbagel changed the title Feat add tvdb indexer feat: add tvdb indexer Jul 27, 2024
@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@DjordyKoert
Copy link

DjordyKoert commented Oct 19, 2024 •
edited
Loading

Any update on this feature? 👀

I think this would help with the issue described here #648

@TOomaAh
Copy link
Contributor Author

TOomaAh commented Oct 19, 2024

Any update on this feature? 👀

I think this would help with the issue described here #648

Sorry, I've got a lot of work at the moment but I've continued to work on it, I'm trying to use directly the api that sonarr uses, skyhook.

@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Oct 19, 2024
@gauthier-th
Copy link
Collaborator

Looks like half of the tests are failing. Could you take a look and try to fix them? And add some for TVDB?

@TOomaAh
Copy link
Contributor Author

TOomaAh commented Oct 27, 2024

Looks like half of the tests are failing. Could you take a look and try to fix them? And add some for TVDB?

Hello, indeed, I solved the problem of the existing tests and I added tests for tvdb.

@gauthier-th gauthier-th marked this pull request as ready for review October 28, 2024 21:30
gauthier-th
gauthier-th reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go into detail, but the overall looks good.
I'll make a more in-depth review later.

server/api/indexer/themoviedb/index.ts Outdated Show resolved Hide resolved
server/lib/settings/index.ts Outdated Show resolved Hide resolved
server/routes/settings/tvdb.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions bot added merge conflict Cannot merge due to merge conflicts and removed merge conflict Cannot merge due to merge conflicts labels Nov 3, 2024
@gauthier-th
Copy link
Collaborator

This can be tested with the preview-tvdb-indexer tag.

@gauthier-th gauthier-th added the preview PRs deployed for testing with tag `:preview-prxx` label Nov 17, 2024
@gauthier-th
Copy link
Collaborator

gauthier-th commented Nov 17, 2024 •
edited by fallenbagel
Loading

@TOomaAh next time you should rebase instead of merge. Merging makes the history look messy.

It's also in our contributing guide to rebase instead of merging

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Nov 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@TOomaAh TOomaAh force-pushed the feat-add-tvdb-indexer branch from 2ee5535 to f447870 Compare December 12, 2024 00:55
@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Dec 12, 2024
@gauthier-th gauthier-th mentioned this pull request Dec 30, 2024
Closed
1 task
@TOomaAh TOomaAh force-pushed the feat-add-tvdb-indexer branch from a97fc02 to 8c2b82c Compare January 8, 2025 18:10
TOomaAh and others added 21 commits January 15, 2025 18:41
@TOomaAh
refactor(tvdb): replace tvdb api by skyhook
3137703
@TOomaAh
fix: error during get episodes
f8e8c29
@TOomaAh
fix: error if tmdb poster is null
a5406e7
@TOomaAh
refactor: clean tvdb indexer code
c84ca3d
@TOomaAh
fix: wrong language with tmdb indexer
ad42c4e
@TOomaAh
style: replace avalaible to available
79fa6a3
@TOomaAh
style: tvdb.login to tvdb.test
41b471d
@TOomaAh
fix(test): fix discover test
204ecf1
@TOomaAh
fix(test): wrong url tv-details
501eac9
@TOomaAh
test(tvdb): add tvdb tests
51de966
@TOomaAh
style(tvdb): rename pokemon to correct tv show
b90ffc6
@TOomaAh
refactor(indexer): remove unused getSeasonIdentifier method
2193755
@TOomaAh
refactor(settings): replace tvdb object to boolean type
b325805
@TOomaAh
refactor(tmdb): reduce still path condition
f37312c
@TOomaAh
test(tvdb): change 'use' to 'tvdb' condition check
b84dd14
@TOomaAh
fix(tmdb): fix build
40fabcc 
fix build after rebase
@TOomaAh
fix(build): revert package.json
619087c
@TOomaAh
fix(tvdb): ensure that seasons contain data
4336230
@TOomaAh
refactor(swagger): fix /tvdb/test response
c6f2cc1
@TOomaAh
fix(scanner): add tvdb indexer for scanner
03f97bd
@fallenbagel @TOomaAh
style(mediarequest): apply prettier
353d079
@TOomaAh TOomaAh force-pushed the feat-add-tvdb-indexer branch from 0fe1827 to 353d079 Compare January 15, 2025 17:43
@TOomaAh
fix(build): remove circular dependency
973e8d1 
move emby header to jellyfin class instead externalapi class
@markus101
Copy link

Hey @TOomaAh, I'm one of the Sonarr devs and this PR was recently brought to my attention.

I see that this is using Skyhook for TheTVDB data; our agreement with TheTVDB is for Skyhook to be hosted for Sonarr's direct use only and cannot be used with other applications as it's being used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallenbagel fallenbagel fallenbagel requested changes

@gauthier-th gauthier-th gauthier-th left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
preview PRs deployed for testing with tag `:preview-prxx`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TOomaAh @DjordyKoert @gauthier-th @markus101 @fallenbagel