Fix code duplication #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

gabrielademoraes wants to merge 2 commits into falko-org:devel from GCES-Falko-2019-2:issue_252_fix_code_duplication

gabrielademoraes commented Nov 26, 2019

Proposed Changes

Fixing code duplication appointed by Code Climate (https://codeclimate.com/github/fga-gpp-mds/Falko-2017.2-BackEnd/issues?category=duplication&engine_name%5B%5D=structure&engine_name%5B%5D=duplication) creating a method that do both validations. #252

Type of Change

What kind of changes this Pull Request introduces to Falko?

Bugfix
New Feature

Checklist

Pull Request's name is self-explanatory and its in English.
There are no Rubocop issues.
Travis build has success (tests, code climate and codacy checks).
Pull Request is linked to an existing issue.
Seeds have been created to the new User Stories.

gabrielademoraes added 2 commits

November 22, 2019 16:22


          Creating method that validates both elements.

aa1b18d


          Removing comments.

9684c40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet