Upgrade nanopub to v2.0.0
#201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make sure the files are properly formatted (similar to the nanopub package setup). Update nanopub dependency to 2.0.0 (no need for java anymore) and make the changes required. Update rdflib dependency to v6. Remove some mocks from the tests (mainly related to the NanopubClient used for publishing that is not used anymore for this purpose). Make some changes to the tests (mainly related to URIs not valid). All tests pass successfully on python3.9
…ful anymore. Move conftest.py in the tests/ folder
…http://www.example.org/unpublished by http://purl.org/nanopub/temp/ which is better recognized by the nanopub library as a temp URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @raar1 , I upgraded the
nanopubdependency to use>=2.0.0, which remove the need for javaI did not needed to make a lot of changes, the Nanopub publish is called only at 1 place. And nothing changes for the end users, apart for not needing java anymore
All tests pass, not 100% sure if everything goes as expected though, there are still some
http://example.org/unpublished-steps in the final nanopubs sometimes, that's maybe normal, but you might want to have a checkI also brought changes similar to the one I made for the
nanopublibrary to usepyproject.toml,hatchbuild backend, andpre-commitfor the development workflow. Everything is described in theCONTRIBUTING.mdAnd I upgraded the
rdflibdependency to>= 6.0.0