Skip to content

Tweak SonarCloud test coverage settings #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Tweak SonarCloud test coverage settings #334

wants to merge 2 commits into from

Conversation

@frankosterfeld
Copy link
Contributor

@frankosterfeld frankosterfeld commented Dec 15, 2023

Make sure it doesn't complain about tests not covered by tests.

@codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99ae7d2) 55.84% compared to head (57c5afe) 57.15%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   55.84%   57.15%   +1.30%     
==========================================
  Files          69       69              
  Lines        7291     7310      +19     
  Branches     2691     2703      +12     
==========================================
+ Hits         4072     4178     +106     
+ Misses       1484     1323     -161     
- Partials     1735     1809      +74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankosterfeld frankosterfeld force-pushed the frank/tweak-sonar-coverage branch from 4f4eb8b to 3df8809 Compare December 15, 2023 12:35
@frankosterfeld frankosterfeld force-pushed the frank/tweak-sonar-coverage branch from 3df8809 to e85d934 Compare December 15, 2023 12:37
@frankosterfeld
Fix test coverage settings
a87126f 
Set new OPENCMW_ENABLE_COVERAGE flag in CI setup.

Make sure SonarCloud doesn't complain about tests not covered by tests.

Add all tests as dependencies of the coverage targets.
@frankosterfeld frankosterfeld force-pushed the frank/tweak-sonar-coverage branch from e85d934 to a87126f Compare December 15, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frankosterfeld