Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshmallow schema maintenance to address RemovedInMarshmallow4Warning results #203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

imrehg
Copy link
Member

@imrehg imrehg commented May 14, 2022

Since the dependency list do not limit the marshmallow version, it is likely prudent to fix the multitude of RemovedInMarshmallow4Warning results that the tests are throwing. Most of them are pretty straightforward, but happy to elaborate.

Tests were run with tox -e py38 -- -Werror to make warnings into errors for the process.

There's one remaining warning that is coming from the marshmallow_enum library, and #202 should be relevant for this.

@acroz
Copy link
Member

acroz commented May 17, 2022

Hey, thanks for this update. Looking at the changelog, it looks like load_default was introduced in 3.13.0. If we merge this PR, we should specify this in our dependencies. Are we ok with requiring 3.13.0 or later? (FWIW I'm not saying we can't - but might be worthwhile for you to think through).

For the sake of completeness, your other updates depend on earlier updates to the API (make_error: 3.0.0, self -> lambda: 3.3.0) so an updated min version to 3.13.0 should cover all.

@imrehg
Copy link
Member Author

imrehg commented May 18, 2022

@acroz that's a good shout, didn't think of that aspect! Given that the release is almost 1 year old, it should be on the safe territory, but I'll check for any side-effects or other considerations, and add the minimum version if it looks okay. Will reping when that's done.

@imrehg
Copy link
Member Author

imrehg commented May 19, 2022

@acroz did the update here because it is sensible, tried installing in the platform with

pip install git+https://github.com/facultyai/faculty.git@schema-maintenance#egg=faculty

and that shows a bit of legacy issue:

sherlockml 0.18.6 requires marshmallow==3.0.0rc3, but you have marshmallow 3.15.0 which is incompatible

I guess that needs a bit of deprecation/transition out process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants