feat(sdk) : adding support for multiple versions of java #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlie430
reviewed
Sep 8, 2025
.github/workflows/generate-sdks.yml
Outdated
| path: sdks | ||
| fetch-depth: 0 | ||
| token: ${{ env.USER_API_KEY }} | ||
| ref: feat/sdk/java-version-workflow |
Contributor
There was a problem hiding this comment.
Do we need to remove this before merging this in?
This reverts commit fa434c8.
charlie430
reviewed
Oct 13, 2025
Comment on lines
15
to
21
| message Chart { | ||
| google.protobuf.Struct template = 1; | ||
| map<string, factset.protobuf.stach.table.Reference> attributes = 2; | ||
| map<string, Plot> plots = 3; | ||
| map<string, Series> series = 4; | ||
| map<string, Data> data = 5; | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
You can exclude these protos in the chart folder as they were experimental and not referenced by v1
Contributor
There was a problem hiding this comment.
removed all protos under chart folder
charlie430
suggested changes
Oct 13, 2025
Contributor
charlie430
left a comment
charlie430
left a comment
There was a problem hiding this comment.
Other than removing the v1 chart protos, LGTM
charlie430
approved these changes
Oct 15, 2025
charlie430
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.