Skip to content

feat(readme) : Added deprecated note to readme file #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sainathsagar merged 4 commits into from
Oct 15, 2025
Merged

feat(readme) : Added deprecated note to readme file #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c95f50
Added deprecated note to readme file
sainathsagar Sep 17, 2025
a65f9ca
addressed review comments
snalkari Oct 13, 2025
6e367bb
Update pom.xml
snalkari Oct 14, 2025
518678a
fixed unit tests issues
snalkari Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
[![maven](https://img.shields.io/maven-central/v/com.factset.analyticsapi/engines-sdk)](https://mvnrepository.com/artifact/com.factset.analyticsapi)
![API version](https://img.shields.io/badge/API-v2-blue)
[![Apache-2 license](https://img.shields.io/badge/license-Apache2-brightgreen.svg)](https://www.apache.org/licenses/LICENSE-2.0)
![Deprecated](https://img.shields.io/badge/status-deprecated-red)

*```**Note: This library is no longer maintained and is deprecated. Please use``` [enterprise-sdk](https://github.com/FactSet/enterprise-sdk) ```instead.```*

Use this library to integrate with FactSet's Analytics APIs. Below APIs are supported by this SDK.

Expand Down
2 changes: 1 addition & 1 deletion tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
<migbase64-version>2.2</migbase64-version>
<javax-annotation-version>1.3.2</javax-annotation-version>
<junit-version>4.13.1</junit-version>
<protobuf-version>3.12.2</protobuf-version>
<protobuf-version>3.25.1</protobuf-version>
<stach-extension-version>1.6.0</stach-extension-version>
<engines-sdk-version>6.2.0</engines-sdk-version>
<poi-ooxml-version>4.0.1</poi-ooxml-version>
Expand Down
13 changes: 7 additions & 6 deletions tests/src/test/java/Api/CommonParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class CommonParameters {
&& !System.getenv("ANALYTICS_API_URL").isEmpty() ? System.getenv("ANALYTICS_API_URL") : "https://api.factset.com";

// PA values
public static final String PA_DEFAULT_DOCUMENT = "PA_DOCUMENTS:DEFAULT";
public static final String PA_DEFAULT_DOCUMENT = "PA3_DOCUMENTS:PA_API_DEFAULT_DOCUMENT-RBICS";
public static final String PA_BENCHMARK_SP500 = "BENCH:SP50";
public static final String PA_BENCHMARK_R1000 = "BENCH:R.1000";
public static final String PA_START_DATE = "-3M";
Expand All @@ -30,17 +30,18 @@ public class CommonParameters {
public static final String SPAR_BENCHMARK_RUSSELL_P_R1000 = "RUSSELL_P:R.2000";
public static final String SPAR_BENCHMARK_RUSSELL_PREFIX = "RUSSELL";
public static final String SPAR_BENCHMARK_RUSSELL_RETURN = "GTR";
public static final String SPARAccount = "client:/aapi/spar3_qa_test_document";

// Vault values
public static final String VAULT_DEFAULT_DOCUMENT = "Client:/aapi/VAULT_QA_PI_DEFAULT_LOCKED";
public static final String VAULT_DEFAULT_ACCOUNT = "CLIENT:/BISAM/REPOSITORY/QA/SMALL_PORT.ACCT";
public static final String VAULT_DEFAULT_DOCUMENT = "CLIENT:/YETI/YETI-API-TEST";
public static final String VAULT_DEFAULT_ACCOUNT = "CLIENT:/YETI/YETI-API-TEST.ACCT";
public static final String VAULT_SECONDARY_ACCOUNT = "CLIENT:/BISAM/REPOSITORY/QA/GLOBAL.ACCT";
public static final String VAULT_START_DATE_FIRST = "20180101";
public static final String VAULT_END_DATE_FIRST = "20180329";
public static final String VAULT_START_DATE_FIRST = "20211231";
public static final String VAULT_END_DATE_FIRST = "20220131";
public static final String VAULT_FREQUENCY_DATE_MONTHLY = "Monthly";

// Pub values
public static final String PUB_DEFAULT_DOCUMENT = "Client:/AAPI/Puma Test Doc.Pub_bridge_pdf";
public static final String PUB_DEFAULT_DOCUMENT = "Client:/AAPI/Puma Narrative Test.PUB_BRIDGE_PDF";
public static final String PUB_DEFAULT_ACCOUNT = "BENCH:SP50";
public static final String DEFAULT_LOOKUP_DIRECTORY = "client:";

Expand Down
2 changes: 1 addition & 1 deletion tests/src/test/java/Api/ComponentsApiTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public void getBySPARComponentIdSuccess() throws ApiException {
apiInstance = new ComponentsApi(apiClient);

try {
getSPARComponentsResponse = apiInstance.getSPARComponentsWithHttpInfo(CommonParameters.SPAR_DEFAULT_DOCUMENT);
getSPARComponentsResponse = apiInstance.getSPARComponentsWithHttpInfo(CommonParameters.SPARAccount);

Assert.assertTrue("Response should be 200 - Success", getSPARComponentsResponse.getStatusCode() == 200);
Assert.assertTrue("Response data should not be null.", getSPARComponentsResponse.getData().getData().size() != 0);
Expand Down