fix(quant-tests): Added custom max age for quant tests #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainathsagar
requested review from
AkankshaAcharya,
ksreeramoj and
vamshimupparaju
sainathsagar
changed the title
sainathsagar
changed the title
sainathsagar
removed request for
AkankshaAcharya,
ksreeramoj and
vamshimupparaju
sainathsagar
requested review from
AkankshaAcharya,
ksreeramoj and
vamshimupparaju
Comment on lines
+41
to
+42
| public static readonly string Quant_Custom_Max_Age = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("QUANT_CUSTOM_MAX_AGE")) | ||
| ? Environment.GetEnvironmentVariable("QUANT_CUSTOM_MAX_AGE") : "5"; |
Contributor
There was a problem hiding this comment.
Suggested change
| public static readonly string Quant_Custom_Max_Age = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("QUANT_CUSTOM_MAX_AGE")) | |
| ? Environment.GetEnvironmentVariable("QUANT_CUSTOM_MAX_AGE") : "5"; | |
| public static readonly string Quant_Custom_Max_Age = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("QUANT_CUSTOM_MAX_AGE")) | |
| ? Environment.GetEnvironmentVariable("QUANT_CUSTOM_MAX_AGE") : "5"; |
AkankshaAcharya
approved these changes
Oct 15, 2025
ksreeramoj
reviewed
Oct 16, 2025
vamshimupparaju
approved these changes
Oct 22, 2025
Vivekjvs
reviewed
Oct 22, 2025
tests/FactSet.AnalyticsAPI.Engines.Test/Api/QuantCalculationsApiTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added custom max age for the quant tests due to unnecessary frequent polling to get status endpoint which is resulting in time outs from backend quant service.