Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 6, 2026

The Conan build instructions used deprecated --install-folder flag and were missing required parameters, causing compilation failures on Linux and Windows.

Changes

Linux instructions (lines 38-49):

  • --install-folder--output-folder (Conan 2.x)
  • Added -s build_type=RelWithDebInfo for correct dependency linking
  • Added -DBUILDING_WITH_CONAN=ON CMake flag

Windows instructions (lines 160-170):

  • --install-folder--output-folder (Conan 2.x)
  • Added -s build_type=Release for correct dependency linking
  • Added -DBUILDING_WITH_CONAN=ON CMake flag

Corrected instructions

# Linux
conan install src/PlotJuggler --output-folder build/PlotJuggler \
      --build missing -pr:b=default -s build_type=RelWithDebInfo

cmake -S src/PlotJuggler -B build/PlotJuggler \
      -DCMAKE_TOOLCHAIN_FILE=$CMAKE_TOOLCHAIN \
      -DCMAKE_INSTALL_PREFIX=install \
      -DCMAKE_POLICY_DEFAULT_CMP0091=NEW \
      -DBUILDING_WITH_CONAN=ON

Aligns with existing conan_build.sh and CI workflow configurations.

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG]: Conan compile instructions for Linux are wrong</issue_title>
<issue_description>Describe the bug
The instructions as given in COMPILE.md are wrong.

PlotJuggler/COMPILE.md

Lines 38 to 48 in 1168247

conan install src/PlotJuggler --install-folder build/PlotJuggler \
--build missing -pr:b=default
export CMAKE_TOOLCHAIN=$(pwd)/build/PlotJuggler/conan_toolchain.cmake
cmake -S src/PlotJuggler -B build/PlotJuggler \
-DCMAKE_TOOLCHAIN_FILE=$CMAKE_TOOLCHAIN \
-DCMAKE_INSTALL_PREFIX=install \
-DCMAKE_POLICY_DEFAULT_CMP0091=NEW
cmake --build build/PlotJuggler --config RelWithDebInfo --target install

They don't work for two reasons:

  1. --install-folder is not valid (also mentioned in Conan compile instructions for Windows are wrong #982), it should be --output-folder
  2. conan install needs to know the config type, otherwise it does not link the dependencies correctly.

To Reproduce
Attempt to execute instructions are mentioned in COMPILE.md on a linux host.

Expected behavior
Compilation succeeds.

System details

  • OS: Pop!_OS 24.04 LTS
  • Platform: Linux
  • Version: 1168247
  • Conan version: 2.24.0

Additional context
Add any other context about the problem here.

The following build instructions (on Linux with Conan) work:

#!/bin/sh
conan install src/PlotJuggler --output-folder build/PlotJuggler \
      --build missing -pr:b=default -s build_type=RelWithDebInfo

export CMAKE_TOOLCHAIN=$(pwd)/build/PlotJuggler/conan_toolchain.cmake

cmake -S src/PlotJuggler -B build/PlotJuggler \
      -DCMAKE_TOOLCHAIN_FILE=$CMAKE_TOOLCHAIN  \
      -DCMAKE_INSTALL_PREFIX=install \
      -DCMAKE_POLICY_DEFAULT_CMP0091=NEW \
      -DBUILDING_WITH_CONAN=ON

cmake --build build/PlotJuggler --config RelWithDebInfo --target install -j14 
```</issue_description>

<agent_instructions>check the workflow configurations to see how conan is used correctly</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix incorrect Conan compile instructions for Linux Fix Conan 2.x build instructions in COMPILE.md Jan 6, 2026
Copilot AI requested a review from facontidavide January 6, 2026 13:38
@facontidavide facontidavide marked this pull request as ready for review January 6, 2026 19:19
@facontidavide facontidavide merged commit b2aa7cb into main Jan 6, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Conan compile instructions for Linux are wrong

2 participants