-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-commit documentation #200
Fix pre-commit documentation #200
Conversation
Yes, I've never used the |
I see your change also removes |
Oh, I guess you commented on |
I was expecting this to be a minor "typo" anyway ;) |
@sscheib can you comment on the changes? I believe you originally committed the change? |
that was indeed an oversight on my end. @schuellerf is correct with the PR. at the time back then there was no new release, which is why I tagged in for my use with the commit hash. Sorry for the inconvenience! |
@sscheib What about the removal of |
it's not strictly necessary. |
Then it's probably worth leaving in the documentation or adding a warning of removing. |
f41e767
to
189025e
Compare
It just felt unnecessary and lengthens the config, but it's ok to just leave it in |
@gir-bot lgtm |
Two minor things.
The name of the revision has to be exactly the same as the git tag, I think. Which (at least until 2.10) is without the "v"?
pass_filenames
is already part of .pre-commit-hooks.yaml so I guess this is obsolete here?