Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fp16 support for sample_farthest_points, ball_query and knn #1929

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

eamonn-zh
Copy link

@eamonn-zh eamonn-zh commented Dec 23, 2024

add fp16 CUDA supports for sample_farthest_points, ball_query functions via AT_DISPATCH_FLOATING_TYPES_AND_HALF and knn

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 23, 2024
@eamonn-zh eamonn-zh changed the title Add fp16/64 support for sample_farthest_points and ball_query Add fp16 support for sample_farthest_points and ball_query Dec 27, 2024
@eamonn-zh eamonn-zh changed the title Add fp16 support for sample_farthest_points and ball_query Add fp16 support for sample_farthest_points, ball_query and knn Dec 27, 2024
@bottler
Copy link
Contributor

bottler commented Feb 24, 2025

(There's no need to keep merging from main. There are no conflicts afaict.)

This could be a useful addition - do you have an application?

My concern here is that it makes builds bigger and slower, which is the opposite of where we really want pytorch3d to be.
A big question: Could these operations be reimplemented in python and be very efficient with torch compile? Or could they be written in openai triton? Or, if the answer is no, could they be compiled on-demand with torch.utils.cpp_extension.load?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants