Skip to content

Conversation

@evtimovi
Copy link
Contributor

@evtimovi evtimovi commented Dec 9, 2025

As in the title, the name made sense originally but it is more intuitive as a generic template string class.

We ran tests with:

uv run pytest -v tests/test_hydra_validation.py tests/test_attack_config_serialization.py tests/attacks/test_registry.py tests/test_results_processing.py tests/results/test_aggregator.py

and they pass

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 9, 2025
@evtimovi evtimovi marked this pull request as draft December 9, 2025 20:39
@evtimovi evtimovi assigned evtimovi and unassigned evtimovi Dec 9, 2025
@evtimovi evtimovi marked this pull request as ready for review December 9, 2025 21:04
Comment on lines 117 to 118
user=self._user_name,
model=agent.get_agent_name(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make these extra fields part of the attack config? Different attacks might want to define their own custom templated fields.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can have as part of the config a list of fields? Or maybe we should use a jinja template for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I moved too fast and forgot about these. Let me do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Check the latest version!

Copy link
Contributor

@dedeswim dedeswim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more template_string that should be changed to agentdojo_important_instructions. Can merge after this has been changed

# Use different component types
uv run prompt-siren run benign +dataset=agentdojo agent.config.model=azure:gpt-5
uv run prompt-siren run attack +dataset=agentdojo +attack=agentdojo
uv run prompt-siren run attack +dataset=agentdojo +attack=template_string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these (and other ones below) also need renaming to agentdojo_important_instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants