Pluginize docker #28
Merged
Pluginize docker #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
dedeswim
suggested changes
Dec 9, 2025
| pytestmark = pytest.mark.anyio | ||
|
|
||
| # Path to test fixtures | ||
| FIXTURES_DIR = Path(__file__).parent / "fixtures" |
Contributor
There was a problem hiding this comment.
I think we should use resources.files from importlib import resources, i.e., use resources.files("tests.integration.fixtures").
This returns a Path-like object on which we can then call str later on
Contributor
Author
There was a problem hiding this comment.
Wait, I am not sure why we need to get an object like this and then cast it back to string; what is the benefit of this?
| test_image: str, | ||
| docker_client_type: str, | ||
| skip_if_des_unavailable, | ||
| create_manager_config, |
Contributor
There was a problem hiding this comment.
nit: ideally we can ask an LLM to add type annotations for the fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request creates a plugin system for what is backing the Docker implementation when the
SandboxManageris docker-based. This allows us to have different plugins based on what Docker libraries we want to use and avoid having to rewrite other parts of theSandboxManagerfor this purpose. Here, we also abstract theaiodockerbehind aLocalDockerplugin.