fix all2all support #201
Open
fix all2all support #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
requested review from
kingchc,
louisfeng,
sunghlin,
shengbao-zheng and
briancoutinho
as code owners
facebook-github-bot
added
the
CLA Signed
|
The fix looks good to me. Thanks for the fix. Let's wait until pytorch/pytorch#149485 is merged. |
|
Hi, @shengfukevin Then, can this Param PR be merged now? |
|
@shengfukevin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
TaekyungHeo
force-pushed
the
sanshang/fix_all2all
branch
from
6b86d24 to
113c54c
Compare
|
@TaekyungHeo has updated the pull request. You must reimport the pull request before landing. |
TaekyungHeo
force-pushed
the
sanshang/fix_all2all
branch
from
113c54c to
21efb25
Compare
|
@TaekyungHeo has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix support to replay all2all.
Depend on PyTorch PR-149485.
Test Plan
constructed 4 rank case to invoke
torch.distributed.all_to_all()andtorch.distributed.all_to_all_single(), then dump trace and replay.