Fix bug when deep copying full config with missing parent #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jesszzzz
force-pushed
the
fix_deepcopy_full_config_bug
branch
from
e457f66 to
8318064
Compare
jesszzzz
force-pushed
the
fix_deepcopy_full_config_bug
branch
from
8318064 to
3bb6398
Compare
jesszzzz
requested review from
andywag,
Sanjay-Ganeshan,
hstonec,
tonykao8080 and
yikaiMeta
tonykao8080
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously the implementation assumed that
OmegaConf.select(subconfig._get_root(), subconfig._get_full_key(None) == subconfigbut this isn't actually the case because sometimessubconfig's parent is set toNonewithout modifying the full key.This PR fixes it by
Removing any
subconfig._get_root()eg. ifNone is parent of B (full key A.B) is parent of C (full key A.B.C) is parent of D (full key A.B.C.D)
then the root of D is B
The key we should use is C.D which is D's full key with B's full key removed from the prefix
If for whatever reason even with this logic, we still can't retrieve the subconfig from the root config correctly, give up on trying to do the full copy and revert to previous behavior
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
New tests pass
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)