Enable local loading of tokenizer for dino.txt #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On clusters accessing internet is not possible sometimes and the get_tokenizer function rise an error. This commit add an option to fix the issue by providing a way to provide a local path containing the vocabulary.
facebook-github-bot
added
the
CLA Signed
Comment on lines
+73
to
+75
| response = requests.get(url) | ||
| response.raise_for_status() | ||
| content = response.content |
Contributor
There was a problem hiding this comment.
@cijose Do you remember why requests was pulled as dependency? Couldn't we simply use builtin Python modules instead?
with urllib.request.urlopen(url) as f:
content = f.read()
| response = requests.get(url) | ||
| response.raise_for_status() | ||
| file_buf = BytesIO(response.content) | ||
| if not local_path: |
Contributor
There was a problem hiding this comment.
Use urllib.parse.urlparse(bpe_path).scheme to distinguish between a URL with a scheme or something that looks like an actual local path?
|
|
||
|
|
||
| def get_tokenizer(): | ||
| def get_tokenizer(local_path=None): |
Contributor
There was a problem hiding this comment.
Minor: def get_tokenizer(bpe_path_or_url: Optional[str] = None)
Contributor
Which error do you get? |
Author
It's just returning a 403 error as the GPU nodes on the cluster are not connected to internet (due to security issues), so unable to request an online url |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On clusters accessing internet is not possible sometimes and the get_tokenizer function rise an error. This commit add an option to fix the issue by providing a way to provide a local path containing the vocabulary.