Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Lower from TC directly to a Halide Stmt #589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abadams
Copy link
Contributor

@abadams abadams commented Jul 26, 2018

Avoid making a DAG of Halide Funcs, and instead just produce a Halide Stmt directly. Should have no observable effect on anything, other than producing slightly simpler variable names (hence the change to the test).

This change makes it possible to add new types of loops and control flow that don't fit into the Halide model currently (e.g. the RNNs in #572 ).

The downside is that it's no longer possible to play with Halide recompute vs reuse scheduling directives, or compare to Halide autoschedulers, as Halide scheduling must start from a DAG of Funcs. We can still use Halide backends if we want, and most of Halide's lowering passes would still apply if we ever want them (e.g. simplification, vectorization).

@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants