Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #{issue number}
Summary
I fix the bbox rotation issue. The bugs are:
Previous failure case:
Test case after fixing
Unit Tests
If your changes touch the
audio
module, please run all of theaudio
tests and paste the output here. Likewise forimage
,text
, &video
. If your changes could affect behavior in multiple modules, please run the tests for all potentially affected modules. If you are unsure of which modules might be affected by your changes, please just run all the unit tests.I had a fail in image test.
Other testing
I can run it on my own test cases. But I'm not sure why it can not pass the rotation unit test. Please let me know if I'm wrong. Thanks!