fix: Added non-avx path for index transposing #12087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67659247 |
✅ Deploy Preview for meta-velox canceled.
|
Summary: This diff creates a different transposeIndex path if XSIMD_WITH_AVX2 is not present. Previously it was simply not supported. Differential Revision: D67659247
tanjialiang
force-pushed
the
export-D67659247
branch
from
9850943 to
67a66d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67659247 |
tanjialiang
changed the title
Comment on lines
+1076
to
+1077
| bits::clearNull(resultNulls, i); | ||
| resultIndices[i] = baseIndices[index]; |
There was a problem hiding this comment.
should this also be done when baseNulls does not exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff creates a different transposeIndex path if XSIMD_WITH_AVX2 is not present. Previously it was simply not supported.
Differential Revision: D67659247