Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Move ConstrainedInputGenerator to velox/common/fuzzer #12080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

misc: Move ConstrainedInputGenerator to velox/common/fuzzer #12080

wants to merge 1 commit into from

Conversation

kagamiori
Copy link
Contributor

@kagamiori kagamiori commented Jan 14, 2025 •
edited
Loading

This is needed for the mono-build for #12080.

Differential Revision: D68137136

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68137136

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 8cac632
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6789af10498e0900088061d0

kagamiori added a commit to kagamiori/velox that referenced this pull request Jan 14, 2025
@kagamiori @facebook-github-bot
misc: Move ConstrainedInputGenerator to velox/common/fuzzer (facebook…
8933e08 
…incubator#12080)

Summary: Pull Request resolved: facebookincubator#12080

Differential Revision: D68137136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68137136

@kagamiori kagamiori mentioned this pull request Jan 14, 2025
Open
kagamiori added a commit to kagamiori/velox that referenced this pull request Jan 14, 2025
@kagamiori @facebook-github-bot
misc: Move ConstrainedInputGenerator to velox/common/fuzzer (facebook…
4607ae6 
…incubator#12080)

Summary: Pull Request resolved: facebookincubator#12080

Reviewed By: xiaoxmeng

Differential Revision: D68137136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68137136

kagamiori added a commit to kagamiori/velox that referenced this pull request Jan 14, 2025
@kagamiori @facebook-github-bot
misc: Move ConstrainedInputGenerator to velox/common/fuzzer (facebook…
3d8de89 
…incubator#12080)

Summary: Pull Request resolved: facebookincubator#12080

Reviewed By: xiaoxmeng

Differential Revision: D68137136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68137136

assignUser
assignUser approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake looks good. There is a failing test and while it sounds unrelated velox_trace_tool_test it fails on both linux builds so it's likely related somehow. Please check: https://github.com/facebookincubator/velox/actions/runs/12775474449/job/35611966104?pr=12080#step:10:870

kagamiori added a commit to kagamiori/velox that referenced this pull request Jan 14, 2025
@kagamiori @facebook-github-bot
misc: Move ConstrainedInputGenerator to velox/common/fuzzer (facebook…
178d556 
…incubator#12080)

Summary: Pull Request resolved: facebookincubator#12080

Reviewed By: xiaoxmeng

Differential Revision: D68137136
kagamiori added a commit to kagamiori/velox that referenced this pull request Jan 14, 2025
@kagamiori @facebook-github-bot
misc: Move ConstrainedInputGenerator to velox/common/fuzzer (facebook…
c542408 
…incubator#12080)

Summary: Pull Request resolved: facebookincubator#12080

Reviewed By: xiaoxmeng

Differential Revision: D68137136
@kagamiori kagamiori force-pushed the export-D68137136 branch 2 times, most recently from 178d556 to c542408 Compare January 14, 2025 23:40
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68137136

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68137136

kagamiori added a commit to kagamiori/velox that referenced this pull request Jan 15, 2025
@kagamiori @facebook-github-bot
misc: Move ConstrainedInputGenerator to velox/common/fuzzer (facebook…
95cba8b 
…incubator#12080)

Summary: Pull Request resolved: facebookincubator#12080

Reviewed By: xiaoxmeng

Differential Revision: D68137136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68137136

@kagamiori @facebook-github-bot
misc: Move ConstrainedInputGenerator to velox/common/fuzzer (facebook…
8cac632 
…incubator#12080)

Summary: Pull Request resolved: facebookincubator#12080

Reviewed By: xiaoxmeng

Differential Revision: D68137136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68137136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

@assignUser assignUser assignUser approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kagamiori @facebook-github-bot @assignUser @xiaoxmeng