[babel-plugin] Remove confusing removeObjectsWithSpreads() utility #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryqdineen
requested review from
Jta26,
ezzak,
mellyeliu,
necolas,
nmn and
vincentriemer
as code owners
meta-cla
bot
added
the
CLA Signed
mellyeliu
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
When working on #1290 I noticed the
Object.entries().filter(Boolean)which seemed redundant as entries will always be truthy. It looks like the functionality that gaveremoveObjectsWithSpreads()its name was removed in #884. For this PR I chose to just inline theObject.fromEntries(Object.entries())call to preserve behavior but it doesn't look like anything specifically relies on the object being shallow cloned. Let me know if i'm missing something obvious. Thanks!Pre-flight checklist
Contribution Guidelines