Skip to content

Clarify rocksdb.is-file-deletions-enabled doc comment #14165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xdeafbeef wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Clarify rocksdb.is-file-deletions-enabled doc comment #14165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/rocksdb/db.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,10 +1291,10 @@ class DB {
// filter and index blocks).
static const std::string kEstimateTableReadersMem;

// "rocksdb.is-file-deletions-enabled" - returns 0 if deletion of obsolete
// files is enabled; otherwise, returns a non-zero number.
// This name may be misleading because true(non-zero) means disable,
// but we keep the name for backward compatibility.
// "rocksdb.is-file-deletions-enabled" - returns 1 when RocksDB is allowed
// to delete obsolete files (DisableFileDeletions counter is 0), and 0
// while file deletions are disabled; name kept for backward
// compatibility.
static const std::string kIsFileDeletionsEnabled;

// "rocksdb.num-snapshots" - returns number of unreleased snapshots of the
Expand Down