Fix: Limit the sorting files based on max_compaction_jobs instead of kNumberFilesToSort to reduce write amplification #14156
+20
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10161 improves compaction performance by using a partial‑sorting mechanism that operates on a fixed number of files (kNumberFilesToSort). However, when the number of concurrent background compaction jobs exceeds kNumberFilesToSort, this strategy causes write amplification. The fix selects sorting files according to the max_compaction_jobs setting in order to mitigate write amplification and keep the performance.
Benchmarks with db_bench fillrandom demonstrate that, when max_compaction_jobs is configured to 128, write amplification is reduced by 25 % without performance degradation.