Fix CompactRange with kForceOptimized in range split scenarios (#12702) #14113
+109
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook#12702) Summary: Fix a bug where CompactRange with BottommostLevelCompaction::kForceOptimized would incorrectly return early when two conditions occurred simultaneously: 1. max_compaction_bytes limit caused input file truncation 2. kForceOptimized filtering removed all files in the truncated batch **Root Cause:** The original code at line 784 would return nullptr immediately when inputs_shrunk was empty, without checking if covering_the_whole_range was false (indicating more files beyond the size limit). **The Fix:** 1. Check covering_the_whole_range before returning nullptr when inputs_shrunk is empty 2. If covering_the_whole_range is false, set compaction_end to signal the caller to continue with remaining files 3. Fix the loop checking remaining files to use inputs_shrunk (which contains the original file list after the swap) Fixes facebook#12702 Test Plan: make db_compaction_test ./db_compaction_test --gtest_filter="DBCompactionTest.ManualCompactionBottomLevelOptimized"
ywave620
force-pushed
the
bugfix-12702
branch
from
f007942 to
d7043ce
Compare
Contributor
Author
|
@cbi42 Could you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix a bug where CompactRange with BottommostLevelCompaction::kForceOptimized would incorrectly return early when two conditions occurred simultaneously:
Root Cause:
The original code at line 784 would return nullptr immediately when inputs_shrunk was empty, without checking if covering_the_whole_range was false (indicating more files beyond the size limit).
The Fix:
Set compaction_end to signal the caller to continue with remaining files when the two conditions are met
Fixes #12702
Test Plan:
make db_compaction_test
./db_compaction_test --gtest_filter="DBCompactionTest.ManualCompactionBottomLevelOptimized"