[compiler] Add reactive flag on scope dependencies #33325
Merged
+143
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2025
jbrown215
approved these changes
May 21, 2025
It was pretty simple to thread this flag through! I've noticed that TS is generally pretty good on giving few errors (not many false positives from inferred types) + fairly accurate source locations, even when I have a file that doesn't parse completely (e.g. mid-edit for a block / expression) |
josephsavona
approved these changes
May 21, 2025
| @@ -381,7 +393,7 @@ function collectNonNullsInBlocks( | |||
| ) { | |||
| const identifier = fn.params[0].identifier; | |||
| knownNonNullIdentifiers.add( | |||
| context.registry.getOrCreateIdentifier(identifier), | |||
| context.registry.getOrCreateIdentifier(identifier, true), | |||
There was a problem hiding this comment.
ah ok, true bc this is the props object
| @@ -375,6 +376,41 @@ export function inferReactivePlaces(fn: HIRFunction): void { | |||
| } | |||
| } | |||
| } while (reactiveIdentifiers.snapshot()); | |||
|
|
|||
| function propagateReactivityToInnerFunctions( | |||
There was a problem hiding this comment.
hoist this to a top-level function?
| @@ -456,6 +456,7 @@ function canMergeScopes( | |||
| new Set( | |||
| [...current.scope.declarations.values()].map(declaration => ({ | |||
| identifier: declaration.identifier, | |||
| reactive: true, | |||
There was a problem hiding this comment.
should areEqualDependencies() update to look at reactivity?
When collecting scope dependencies, mark each dependency with `reactive: true | false`. This prepares for later PRs #33326 and #32099 which rewrite scope dependencies into instructions. Note that some reactive objects may have non-reactive properties, but we do not currently track this. Technically, state[0] is reactive and state[1] is not. Currently, both would be marked as reactive. ```js const state = useState(); ```
mofeiZ
added a commit
that referenced
this pull request
May 22, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32286). * #33326 * #33325 * __->__ #32286
mofeiZ
added a commit
that referenced
this pull request
May 22, 2025
…33326) Inferred effect dependencies now include optional chains. This is a temporary solution while #32099 and its followups are worked on. Ideally, we should model reactive scope dependencies in the IR similarly to `ComputeIR` -- dependencies should be hoisted and all references rewritten to use the hoisted dependencies. ` --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33326). * __->__ #33326 * #33325 * #32286
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32286). * #33326 * #33325 * __->__ #32286 DiffTrain build for [13f2004](13f2004)
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
--- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32286). * #33326 * #33325 * __->__ #32286 DiffTrain build for [13f2004](13f2004)
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
…33326) Inferred effect dependencies now include optional chains. This is a temporary solution while #32099 and its followups are worked on. Ideally, we should model reactive scope dependencies in the IR similarly to `ComputeIR` -- dependencies should be hoisted and all references rewritten to use the hoisted dependencies. ` --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33326). * __->__ #33326 * #33325 * #32286 DiffTrain build for [0d07288](0d07288)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting scope dependencies, mark each dependency with
reactive: true | false. This prepares for later PRs #33326 and #32099 which rewrite scope dependencies into instructions.Note that some reactive objects may have non-reactive properties, but we do not currently track this.
Technically, state[0] is reactive and state[1] is not. Currently, both would be marked as reactive.
Stack created with Sapling. Best reviewed with ReviewStack.