Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(SSR): remove regexp in function escapeHtml #31706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −8
Open

perf(SSR): remove regexp in function escapeHtml #31706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/react-dom-bindings/src/server/escapeTextForBrowser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@

import {checkHtmlStringCoercion} from 'shared/CheckStringCoercion';

const matchHtmlRegExp = /["'&<>]/;

/**
* Escapes special characters and HTML entities in a given html string.
*
Expand All @@ -55,18 +53,13 @@ function escapeHtml(string: string) {
checkHtmlStringCoercion(string);
}
const str = '' + string;
const match = matchHtmlRegExp.exec(str);

if (!match) {
return str;
}

let escape;
let html = '';
let index;
let lastIndex = 0;

for (index = match.index; index < str.length; index++) {
for (index = 0; index < str.length; index++) {
switch (str.charCodeAt(index)) {
case 34: // "
escape = '&quot;';
Expand Down
Loading