Add collapsableChildren prop to View #54463
Closed
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Nov 10, 2025
Summary: Even though the prop is not used on the Android view manager, adding prop diffing will reduce false error reports coming from the Props 2.0 runtime validator. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577393
lenaic
force-pushed
the
export-D86577393
branch
from
8cc05e2 to
7533ec8
Compare
added 2 commits
November 10, 2025 10:05
Summary: With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577389
Summary: Even though the prop is not used on the Android view manager, adding prop diffing will reduce false error reports coming from the Props 2.0 runtime validator. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577393
lenaic
force-pushed
the
export-D86577393
branch
from
7533ec8 to
d613ea6
Compare
|
This pull request has been merged in 4f49081. |
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Nov 15, 2025
Summary: Pull Request resolved: facebook/react-native#54463 Even though the prop is not used on the Android view manager, adding prop diffing will reduce false error reports coming from the Props 2.0 runtime validator. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D86577393 fbshipit-source-id: 748ca90a555eb1f98be551540ad2d54aba08cf25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Even though the prop is not used on the Android view manager, adding prop diffing will reduce false error reports coming from the Props 2.0 runtime validator.
Changelog: [Internal]
Differential Revision: D86577393