Remove equivalent NaN float values from diff output #54462
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2025 18:17
Summary: Compare the output from Props 1.5 with Props 2.0 to detect any missing props in the output coming from Props 2.0. The comparison doesn't run for initial mounts due to Props 1.5 not using the default property values to generate a diff, which is obviously leading to more properties being in the Props 1.5 output that aren't necessary. Changelog: [Internal] Differential Revision: D86577390
Summary: With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Differential Revision: D86577389
meta-cla
bot
added
the
CLA Signed
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Nov 8, 2025
Summary: With `opacity` being initialized to NaN for text attributes, not having the NaN check would mean adding the `opacity` prop to the Props 2.0 diff output even when it was unchanged and still set to NaN Changelog: [Internal] Differential Revision: D86577389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With
opacitybeing initialized to NaN for text attributes, not having the NaN check would mean adding theopacityprop to the Props 2.0 diff output even when it was unchanged and still set to NaNChangelog: [Internal]
Differential Revision: D86577389