Fix android_ripple not working with foreground: false in RN 0.82.1 #54455
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #54372 #54298
The
android_rippleprop onPressablecomponents stopped working in React Native 0.82.1 whenforeground: false(the default value). This regression was introduced by the new background drawable system.Root Cause: The
setFeedbackUnderlaymethod inBackgroundStyleApplicator.ktwas creating a newCompositeBackgroundDrawablewith the ripple effect but not assigning it back to the view's background, causing the ripple to be invisible.Solution: Modified the method to properly assign the new composite drawable containing the ripple effect to
view.background.Changelog:
[ANDROID] [FIXED] - Fix android_ripple not working with foreground: false in Pressable components
Test Plan:
Before the fix: Create a Pressable with android_ripple and foreground: false (default) - no ripple effect appears when pressed.
After the fix: The ripple effect works correctly.
Test case: