-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Add "Dismiss x" button to the "Disconnected from dev server" Fast Refresh notifier message #54445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emily8rown
wants to merge
1
commit into
facebook:main
Choose a base branch
from
emily8rown:export-D86420230
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+270
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86420230. |
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 7, 2025
…resh notifier message (facebook#54445) Summary: Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
1c24a78 to
b75435e
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 7, 2025
…resh notifier message (facebook#54445) Summary: Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 7, 2025
…resh notifier message (facebook#54445) Summary: Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
636bf38 to
53368f2
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 7, 2025
…resh notifier message (facebook#54445) Summary: Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
53368f2 to
a92e7df
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 10, 2025
…resh notifier message (facebook#54445) Summary: Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 10, 2025
…resh notifier message (facebook#54445) Summary: Changelog: DevServer fast refresh banners now have a dismiss button but still tap anywhere to dismiss. Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
a92e7df to
a0204ec
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 10, 2025
…resh notifier message (facebook#54445) Summary: Changelog: DevServer fast refresh banners now have a dismiss button but still tap anywhere to dismiss. Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
a0204ec to
2963f82
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 10, 2025
…resh notifier message (facebook#54445) Summary: Changelog: DevServer fast refresh banners now have a dismiss button but still tap anywhere to dismiss. Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
2963f82 to
e82fbd1
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Nov 10, 2025
…resh notifier message (facebook#54445) Summary: Changelog: DevServer fast refresh banners now have a dismiss button but still tap anywhere to dismiss. Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
e82fbd1 to
04fa474
Compare
…resh notifier message (facebook#54445) Summary: Changelog: DevServer fast refresh banners now have a dismiss button but still tap anywhere to dismiss. Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture. Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button. Differential Revision: D86420230
04fa474 to
3a1e44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a "Dismiss x" button to the fast refresh disconnected banners in the react native DevLoadingView to act as a visual cue for the current click anywhere to dismiss gesture.
Add new parameter to the devLoadingView turbo module to determine whether a message has this dismiss button.
Differential Revision: D86420230