fix: add exception handling to hermes-utils.rb #54411
Closed
+14
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on the React Native macOS upgrade, I ran into this error while fetching hermes during
pod installIt seemed this simply came from an exception in
nightly_tarball_url, which would stop the process. This change adds a fallback so thatpod installcan continue.Changelog:
[INTERNAL] [FIXED] - add exception handling to hermes-utils.rb
Test Plan:
CI should pass