Skip to content

Fix missing enum values in switch statements (xplat/js) #54397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −2
Open

Fix missing enum values in switch statements (xplat/js) #54397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-native/React/CoreModules/RCTPlatform.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@
return @"tv";
case UIUserInterfaceIdiomCarPlay:
return @"carplay";
#if TARGET_OS_VISION
case UIUserInterfaceIdiomVision:
return @"vision";
#endif
case UIUserInterfaceIdiomMac:
return @"mac";
case UIUserInterfaceIdiomUnspecified:
default:
return @"unknown";
}
Expand Down
7 changes: 7 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/css/CSSSyntaxParser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,14 @@ struct CSSComponentValueVisitorDispatcher {
return {};
}

#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wswitch-enum"
#endif
switch (parser.peek().type()) {
#ifdef __clang__
#pragma clang diagnostic pop
#endif
case CSSTokenType::Function:
if (auto ret = visitFunction(visitors...)) {
return *ret;
Expand Down
7 changes: 7 additions & 0 deletions packages/react-native/ReactCommon/yoga/yoga/style/StyleLength.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,14 @@ class StyleLength {
}

constexpr FloatOptional resolve(float referenceLength) {
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wswitch-enum"
#endif
switch (unit_) {
#ifdef __clang__
#pragma clang diagnostic pop
#endif
case Unit::Point:
return value_;
case Unit::Percent:
Expand Down
7 changes: 7 additions & 0 deletions packages/react-native/ReactCommon/yoga/yoga/style/StyleSizeLength.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,14 @@ class StyleSizeLength {
}

constexpr FloatOptional resolve(float referenceLength) {
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wswitch-enum"
#endif
switch (unit_) {
#ifdef __clang__
#pragma clang diagnostic pop
#endif
case Unit::Point:
return value_;
case Unit::Percent:
Expand Down
Loading