Fix potential race conditions when executing commitHooks #53862
+72
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82846245. |
facebook-github-bot
added
p: Facebook
christophpurrer
force-pushed
the
export-D82846245
branch
from
cc03e41 to
42ab383
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 19, 2025
) Summary: Recently we saw `use-after-free race condition` where the ImageFetcher object was being destroyed while still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause could be improper lifecycle management between ImageFetcher destruction and commit hook execution. The fix here modifies `UIManager::shadowTreeWillCommit()` to create a stable snapshot by copying the commitHooks_ vector while holding the lock. ## Reason - If a thread is iterating over `commitHooks_` with a `shared_lock`, and another thread acquires a `unique_lock` to modify the vector (add/remove), the iterator in the first thread can become invalid, leading to a crash (use-after-free or out-of-bounds). - This can happen if the lock is not held for the entire duration of the read or write, or if the lock is not correctly used everywhere commitHooks_ is accessed. Changelog: [Internal] Differential Revision: D82846245
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82846245. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 19, 2025
) Summary: Recently we saw `use-after-free race condition` where the ImageFetcher object was being destroyed while still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause could be improper lifecycle management between ImageFetcher destruction and commit hook execution. The fix here modifies `UIManager::shadowTreeWillCommit()` to create a stable snapshot by copying the commitHooks_ vector while holding the lock. ## Reason - If a thread is iterating over `commitHooks_` with a `shared_lock`, and another thread acquires a `unique_lock` to modify the vector (add/remove), the iterator in the first thread can become invalid, leading to a crash (use-after-free or out-of-bounds). - This can happen if the lock is not held for the entire duration of the read or write, or if the lock is not correctly used everywhere commitHooks_ is accessed. Changelog: [Internal] Differential Revision: D82846245
christophpurrer
force-pushed
the
export-D82846245
branch
from
42ab383 to
160497a
Compare
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82846245. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 20, 2025
) Summary: Recently we saw `use-after-free race condition` where the ImageFetcher object was being destroyed while still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause could be improper lifecycle management between ImageFetcher destruction and commit hook execution. The fix here modifies `UIManager::shadowTreeWillCommit()` to create a stable snapshot by copying the commitHooks_ vector while holding the lock. ## Reason - If a thread is iterating over `commitHooks_` with a `shared_lock`, and another thread acquires a `unique_lock` to modify the vector (add/remove), the iterator in the first thread can become invalid, leading to a crash (use-after-free or out-of-bounds). - This can happen if the lock is not held for the entire duration of the read or write, or if the lock is not correctly used everywhere commitHooks_ is accessed. Changelog: [Internal] Differential Revision: D82846245
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 20, 2025
) Summary: Recently we saw `use-after-free race condition` where the ImageFetcher object was being destroyed while still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause could be improper lifecycle management between ImageFetcher destruction and commit hook execution. The fix here modifies `UIManager::shadowTreeWillCommit()` to create a stable snapshot by copying the commitHooks_ vector while holding the lock. ## Reason - If a thread is iterating over `commitHooks_` with a `shared_lock`, and another thread acquires a `unique_lock` to modify the vector (add/remove), the iterator in the first thread can become invalid, leading to a crash (use-after-free or out-of-bounds). - This can happen if the lock is not held for the entire duration of the read or write, or if the lock is not correctly used everywhere commitHooks_ is accessed. Changelog: [Internal] Differential Revision: D82846245
christophpurrer
force-pushed
the
export-D82846245
branch
from
160497a to
d200c2e
Compare
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82846245. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 20, 2025
) Summary: Recently we saw `use-after-free race condition` where the ImageFetcher object was being destroyed while still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause could be improper lifecycle management between ImageFetcher destruction and commit hook execution. The fix here modifies `UIManager::shadowTreeWillCommit()` to create a stable snapshot by copying the commitHooks_ vector while holding the lock. ## Reason - If a thread is iterating over `commitHooks_` with a `shared_lock`, and another thread acquires a `unique_lock` to modify the vector (add/remove), the iterator in the first thread can become invalid, leading to a crash (use-after-free or out-of-bounds). - This can happen if the lock is not held for the entire duration of the read or write, or if the lock is not correctly used everywhere commitHooks_ is accessed. Changelog: [Internal] Differential Revision: D82846245
christophpurrer
force-pushed
the
export-D82846245
branch
from
d200c2e to
ab61f78
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 24, 2025
…mitHooks (facebook#53862) Summary: Recently, we observed a `use-after-free race condition` where the ImageFetcher object was destroyed while it was still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause appears to be improper lifecycle management between ImageFetcher destruction and commit hook execution. The issue seems to be that `UIManagerCommitHook*` are raw pointers. If we register or unregister them off the JS thread, we will encounter issues with the lifecycle management of the commit hooks. Therefore, it is advisable to revert parts of this change: [https://github.com/facebook/react-native/pull/53491/files](https://github.com/facebook/react-native/pull/53491/files) and remove `UIManagerCommitHookManager`. Alternatively, we can register or unregister the CommitHook by scheduling a task on the RuntimeScheduler and accessing the UIManagerBinding. Changelog: [Internal] Differential Revision: D82846245
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82846245. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 24, 2025
…mitHooks (facebook#53862) Summary: Recently, we observed a `use-after-free race condition` where the ImageFetcher object was destroyed while it was still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause appears to be improper lifecycle management between ImageFetcher destruction and commit hook execution. The issue seems to be that `UIManagerCommitHook*` are raw pointers. If we register or unregister them off the JS thread, we will encounter issues with the lifecycle management of the commit hooks. Therefore, it is advisable to revert parts of this change: [https://github.com/facebook/react-native/pull/53491/files](https://github.com/facebook/react-native/pull/53491/files) and remove `UIManagerCommitHookManager`. Alternatively, we can register or unregister the CommitHook by scheduling a task on the RuntimeScheduler and accessing the UIManagerBinding. Changelog: [Internal] Differential Revision: D82846245
christophpurrer
force-pushed
the
export-D82846245
branch
from
ab61f78 to
b38b4de
Compare
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82846245. |
christophpurrer
force-pushed
the
export-D82846245
branch
from
b38b4de to
7ff03a1
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 24, 2025
…mitHooks (facebook#53862) Summary: Recently, we observed a `use-after-free race condition` where the ImageFetcher object was destroyed while it was still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause appears to be improper lifecycle management between ImageFetcher destruction and commit hook execution. The issue seems to be that `UIManagerCommitHook*` are raw pointers. If we register or unregister them off the JS thread, we will encounter issues with the lifecycle management of the commit hooks. Therefore, it is advisable to revert parts of this change: [https://github.com/facebook/react-native/pull/53491/files](https://github.com/facebook/react-native/pull/53491/files) and remove `UIManagerCommitHookManager`. Alternatively, we can register or unregister the CommitHook by scheduling a task on the RuntimeScheduler and accessing the UIManagerBinding. Changelog: [Internal] Differential Revision: D82846245
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82846245. |
…mitHooks (facebook#53862) Summary: Recently, we observed a `use-after-free race condition` where the ImageFetcher object was destroyed while it was still registered as a UIManagerCommitHook. The crash occurred in `std::vector::size()` at line 635 when accessing corrupted memory. The root cause appears to be improper lifecycle management between ImageFetcher destruction and commit hook execution. The issue seems to be that `UIManagerCommitHook*` are raw pointers. If we register or unregister them off the JS thread, we will encounter issues with the lifecycle management of the commit hooks. Therefore, it is advisable to revert parts of this change: [https://github.com/facebook/react-native/pull/53491/files](https://github.com/facebook/react-native/pull/53491/files) and remove `UIManagerCommitHookManager`. Alternatively, we can register or unregister the CommitHook by scheduling a task on the RuntimeScheduler and accessing the UIManagerBinding. Changelog: [Internal] Differential Revision: D82846245
christophpurrer
force-pushed
the
export-D82846245
branch
from
7ff03a1 to
e3f1dbb
Compare
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82846245. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Recently we saw use-after-free race condition where the ImageFetcher object was being destroyed while still registered as a UIManagerCommitHook.
The crash occurred in std::vector::size() at line 635 when accessing corrupted memory.
The root cause could be improper lifecycle management between ImageFetcher destruction and commit hook execution.
The fix here modifies UIManager::shadowTreeWillCommit() to create a stable snapshot by copying the commitHooks_ vector while holding the lock.
Changelog: [Internal]
Differential Revision: D82846245