Skip to content

Remove unused RCTHermesInstance field #53858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+11 −23
Closed

Remove unused RCTHermesInstance field #53858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,28 @@
* LICENSE file in the root directory of this source tree.
*/

#import <UIKit/UIKit.h>

#import <cxxreact/MessageQueueThread.h>
#import <hermes/Public/CrashManager.h>
#import <jsi/jsi.h>
#import <react/runtime/JSRuntimeFactory.h>
#import <react/runtime/hermes/HermesInstance.h>

namespace facebook::react {

class MessageQueueThread;

using CrashManagerProvider =
std::function<std::shared_ptr<::hermes::vm::CrashManager>()>;

// ObjC++ wrapper for HermesInstance.cpp
class RCTHermesInstance : public JSRuntimeFactory {
public:
RCTHermesInstance();
RCTHermesInstance(CrashManagerProvider crashManagerProvider);
RCTHermesInstance() : RCTHermesInstance(nullptr, false) {}
RCTHermesInstance(CrashManagerProvider crashManagerProvider)
: RCTHermesInstance(std::move(crashManagerProvider), false) {}
RCTHermesInstance(
CrashManagerProvider crashManagerProvider,
bool allocInOldGenBeforeTTI);
bool allocInOldGenBeforeTTI)
: _crashManagerProvider(std::move(crashManagerProvider)),
_allocInOldGenBeforeTTI(allocInOldGenBeforeTTI) {}

std::unique_ptr<JSRuntime> createJSRuntime(
std::shared_ptr<MessageQueueThread> msgQueueThread) noexcept override;
Expand All @@ -34,7 +35,6 @@ class RCTHermesInstance : public JSRuntimeFactory {

private:
CrashManagerProvider _crashManagerProvider;
std::unique_ptr<HermesInstance> _hermesInstance;
bool _allocInOldGenBeforeTTI;
};

Expand Down
18 changes: 3 additions & 15 deletions ...ages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHermesInstance.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,14 @@

#import "RCTHermesInstance.h"

namespace facebook::react {

RCTHermesInstance::RCTHermesInstance() : RCTHermesInstance(nullptr, false) {}

RCTHermesInstance::RCTHermesInstance(CrashManagerProvider crashManagerProvider)
: RCTHermesInstance(std::move(crashManagerProvider), false)
{
}
#import <react/runtime/hermes/HermesInstance.h>

RCTHermesInstance::RCTHermesInstance(CrashManagerProvider crashManagerProvider, bool allocInOldGenBeforeTTI)
: _crashManagerProvider(std::move(crashManagerProvider)),
_hermesInstance(std::make_unique<HermesInstance>()),
_allocInOldGenBeforeTTI(allocInOldGenBeforeTTI)
{
}
namespace facebook::react {

std::unique_ptr<JSRuntime> RCTHermesInstance::createJSRuntime(
std::shared_ptr<MessageQueueThread> msgQueueThread) noexcept
{
return facebook::react::HermesInstance::createJSRuntime(
return HermesInstance::createJSRuntime(
_crashManagerProvider ? _crashManagerProvider() : nullptr, std::move(msgQueueThread), _allocInOldGenBeforeTTI);
}

Expand Down
Loading