fix(test): fix RNTester iOS unit and integration tests #53848
+357
−288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifecycle-originating updates from DeviceEventEmitter
…s, do not attach debugger to tests by default
meta-cla
bot
added
the
CLA Signed
artus9033
force-pushed
the
fix/rntester-tests
branch
from
9e9630c to
c9484f1
Compare
artus9033
changed the title
facebook-github-bot
added
the
Shared with Meta
|
Absolutely, thanks for the comments, I'll address them today. |
… the default export in IntegrationTestsApp
…nUtils.set_react_codegen_podspec_generated
artus9033
commented
Sep 24, 2025
| installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result| | ||
| if pod_name.to_s == target_pod_name | ||
| target_installation_result.native_target.build_configurations.each do |config| | ||
| if configuration_type == nil || (configuration_type != nil && config.type == configuration_type) |
There was a problem hiding this comment.
In this file, indentation was messed up
artus9033
commented
Sep 24, 2025
| # Assert | ||
| assert_equal(DirMock.exist_invocation_params, [codegen_path, codegen_path]) | ||
| assert_equal(DirMock.glob_invocation, ["#{codegen_path}/*", "#{codegen_path}/*"]) | ||
| assert_equal(DirMock.exist_invocation_params, [codegen_path]) |
There was a problem hiding this comment.
This is related to most (although, not all) assert_equal invocations in Ruby tests: the order of arguments is inverted, i.e., expected is swapped with actual. The signature is assert_equal(exp, act, msg = nil), while here and in all other places, the first argument is the actual value and the second is the expected value.
This deteriorates DX since makes it misleading to browse the messages of failed assertions:
artus9033
force-pushed
the
fix/rntester-tests
branch
3 times, most recently
from
b37ee40 to
fe3d3de
Compare
artus9033
force-pushed
the
fix/rntester-tests
branch
5 times, most recently
from
2d0b42f to
dbbaf26
Compare
artus9033
force-pushed
the
fix/rntester-tests
branch
from
dbbaf26 to
f4b1eb5
Compare
artus9033
force-pushed
the
fix/rntester-tests
branch
from
9741b2a to
bf04df5
Compare
This reverts commit 8fd5bc2.
…architecture bridge, which throws if used
|
Thank you Riccardo @cipolleschi , #54421 unblocked this PR - build & tests are now passing. I also disabled or skipped the tests that depend on legacy architecture (bridge). Would you re-review the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes problems with unit & integration tests in the iOS RNTester project, related to: compilation errors, JS problems, missing mocks & outdated baselines.
Changelog:
[GENERAL] [FIXED] - IntegrationTestsApp not registering components under proper names, breaking integration tests
[GENERAL] [FIXED] - IntegrationTestsApp flow types
[GENERAL] [FIXED] - Re-enabled iOS unit & integration tests, Ruby tests on CI
[IOS] [FIXED] - Fixed Ruby scripting tests, refactored order of arguments to
assert_equalswhere it was swapped[IOS] [FIXED] - Reconfigured CI iOS test runner to run on iPhone 16, iOS 18.1, since the previous device was missing in the runner setup
[IOS] [FIXED] - Compilation errors of iOS unit tests
[IOS] [FIXED] - Fixed logic of broken iOS tests, add missing mocks
[IOS] [FIXED] - Disabled / skipped unit & integration tests that are coupled with legacy architecture bridge, which now throws upon initialization
Test Plan: