fix(test): fix RNTester iOS unit and integration tests #53848

artus9033 · 2025-09-18T22:00:09Z

Summary:

This PR fixes problems with unit & integration tests in the iOS RNTester project, related to: compilation errors, JS problems, missing mocks & outdated baselines.

Changelog:

[GENERAL] [FIXED] - IntegrationTestsApp not registering components under proper names, breaking integration tests
[GENERAL] [FIXED] - IntegrationTestsApp flow types
[GENERAL] [FIXED] - Re-enabled iOS unit & integration tests, Ruby tests on CI
[IOS] [FIXED] - Fixed Ruby scripting tests, refactored order of arguments to assert_equals where it was swapped
[IOS] [FIXED] - Reconfigured CI iOS test runner to run on iPhone 16, iOS 18.1, since the previous device was missing in the runner setup
[IOS] [FIXED] - Compilation errors of iOS unit tests
[IOS] [FIXED] - Fixed logic of broken iOS tests, add missing mocks

Test Plan:

iOS tests pass:

When run from dedicated xcschemes:

When run from the RNTester scheme (command + U):

Ruby scripting tests pass:

CI - green

…ifecycle-originating updates from DeviceEventEmitter

…ateFallbacks

…s, do not attach debugger to tests by default

cipolleschi

Amazing job, I left a couple of comments.

We also have in CI a flag here and here that leverage these tests.

It would be nice if we can enable them to run in CI so we can keep them checked while we develop react native.

Can you update the PR with that?

packages/rn-tester/Podfile.lock

packages/rn-tester/IntegrationTests/PromiseTest.js

artus9033 · 2025-09-23T09:15:03Z

Absolutely, thanks for the comments, I'll address them today.

… the default export in IntegrationTestsApp

…nUtils.set_react_codegen_podspec_generated

artus9033 · 2025-09-24T16:30:15Z

packages/react-native/scripts/cocoapods/__tests__/codegen_utils-test.rb

+        original_define_singleton_method = CodegenUtils.method(:assert_codegen_folder_is_empty)
+        CodegenUtils.define_singleton_method(:assert_codegen_folder_is_empty) do |*args, **kwargs|
+            # no-op
+        end
+


This mock was missing

artus9033 · 2025-09-24T16:31:29Z

packages/react-native/scripts/cocoapods/__tests__/codegen_utils-test.rb

-            "/MyModuleSpecs/MyModule.h",
-            "#{codegen_path}/MyModuleSpecs/MyModule.mm",
-            "#{codegen_path}/react/components/MyComponent/ShadowNode.h",
-            "#{codegen_path}/react/components/MyComponent/ShadowNode.mm",
+            codegen_path


In this baseline, these files apparently are no longer present anywhere

artus9033 · 2025-09-24T16:33:57Z

packages/react-native/scripts/cocoapods/__tests__/jsengine-test.rb

        # Assert
-        assert_equal($podInvocationCount, 3)
-        assert_equal($podInvocation["React-jsi"][:path], "../../ReactCommon/jsi")
+        assert_equal($podInvocationCount, 2)


The setup_hermes helper now only adds 2 pods

artus9033 · 2025-09-24T16:42:10Z

packages/react-native/scripts/cocoapods/__tests__/new_architecture-test.rb

-        folly_config = Helpers::Constants.folly_config
-        folly_compiler_flags = folly_config[:compiler_flags]


This is unused. The NewArchitectureHelper has a getter of that name, but no setter. I tried implementing it, but test results haven't change, so I assumed this is dead code. WDYT @cipolleschi ?

artus9033 · 2025-09-24T16:42:45Z

packages/react-native/scripts/cocoapods/__tests__/new_architecture-test.rb

-        assert_equal(spec.pod_target_xcconfig["HEADER_SEARCH_PATHS"], "\"$(PODS_ROOT)/boost\" \"$(PODS_ROOT)/Headers/Private/Yoga\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/fast_float/include\" \"$(PODS_ROOT)/fmt/include\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-graphics/React_graphics.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-graphics/React_graphics.framework/Headers/react/renderer/graphics/platform/ios\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers/react/renderer/components/view/platform/cxx\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-FabricImage/React_FabricImage.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon/ReactCommon.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon/ReactCommon.framework/Headers/react/nativemodule/core\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-NativeModulesApple/React_NativeModulesApple.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-RCTFabric/RCTFabric.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-utils/React_utils.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-featureflags/React_featureflags.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-debug/React_debug.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-ImageManager/React_ImageManager.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-rendererdebug/React_rendererdebug.framework/Headers\"")
+        assert_equal(
+            spec.pod_target_xcconfig["HEADER_SEARCH_PATHS"],
+            [
+                "\"$(PODS_ROOT)/Headers/Private/Yoga\"",
+                "$(PODS_ROOT)/glog",
+                "$(PODS_ROOT)/boost",
+                "$(PODS_ROOT)/DoubleConversion",
+                "$(PODS_ROOT)/fast_float/include",
+                "$(PODS_ROOT)/fmt/include",
+                "$(PODS_ROOT)/SocketRocket",
+                "$(PODS_ROOT)/RCT-Folly"
+            ]
+        )


This apparently is the correct baseline currently

artus9033 · 2025-09-24T16:46:50Z

packages/react-native/scripts/cocoapods/__tests__/new_architecture-test.rb

+        )
        assert_equal(spec.pod_target_xcconfig["CLANG_CXX_LANGUAGE_STANDARD"], "c++20")
-        assert_equal(spec.pod_target_xcconfig["OTHER_CPLUSPLUSFLAGS"], "$(inherited) -DRCT_NEW_ARCH_ENABLED=1")
+        assert_equal(spec.pod_target_xcconfig["OTHER_CPLUSPLUSFLAGS"], "$(inherited) -DRCT_NEW_ARCH_ENABLED=1 ")


This will touch not only this line, but all other occurences of -DRCT_NEW_ARCH_ENABLED=1 in the baselines: apparently, the current implementation appends a trailing whitespace to the define (source here). Even in the same file, it appears that the whitespace is intentionally being stripped in one place. I tried stripping it and the tests still pass. I wanted to consult with you Riccardo @cipolleschi if you agree that we are safe to strip this one?

artus9033 · 2025-09-24T16:47:34Z

packages/react-native/scripts/cocoapods/__tests__/new_architecture-test.rb

-        assert_equal(first_xcconfig.attributes["OTHER_CPLUSPLUSFLAGS"], "$(inherited) -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_CFG_NO_COROUTINES=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -Wno-comma -Wno-shorten-64-to-32")
+        assert_equal(first_xcconfig.attributes["OTHER_CPLUSPLUSFLAGS"], "$(inherited) ")
        assert_equal(first_xcconfig.save_as_invocation, ["a/path/First.xcconfig"])
-        assert_equal(second_xcconfig.attributes["OTHER_CPLUSPLUSFLAGS"], "$(inherited) -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_CFG_NO_COROUTINES=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -Wno-comma -Wno-shorten-64-to-32")
+        assert_equal(second_xcconfig.attributes["OTHER_CPLUSPLUSFLAGS"], "$(inherited) ")
        assert_equal(second_xcconfig.save_as_invocation, ["a/path/Second.xcconfig"])
-        assert_equal(react_core_debug_config.build_settings["OTHER_CPLUSPLUSFLAGS"], "$(inherited) -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_CFG_NO_COROUTINES=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -Wno-comma -Wno-shorten-64-to-32")
-        assert_equal(react_core_release_config.build_settings["OTHER_CPLUSPLUSFLAGS"], "$(inherited) -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_CFG_NO_COROUTINES=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -Wno-comma -Wno-shorten-64-to-32")
+        assert_equal(react_core_debug_config.build_settings["OTHER_CPLUSPLUSFLAGS"], "$(inherited) ")
+        assert_equal(react_core_release_config.build_settings["OTHER_CPLUSPLUSFLAGS"], "$(inherited) ")


@cipolleschi Riccardo, could you verify this is correct behaviour for an old arch scenario?

artus9033 · 2025-09-24T16:49:27Z

packages/react-native/scripts/cocoapods/__tests__/utils-test.rb

+            expected_search_path = "$(inherited) ${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon/ReactCommon.framework/Headers ${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon/ReactCommon.framework/Headers/react/nativemodule/core ${PODS_CONFIGURATION_BUILD_DIR}/React-runtimeexecutor/React_runtimeexecutor.framework/Headers ${PODS_CONFIGURATION_BUILD_DIR}/React-runtimeexecutor/React_runtimeexecutor.framework/Headers/platform/ios ${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon-Samples/ReactCommon_Samples.framework/Headers ${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon-Samples/ReactCommon_Samples.framework/Headers/platform/ios ${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers/react/renderer/components/view/platform/cxx ${PODS_CONFIGURATION_BUILD_DIR}/React-NativeModulesApple/React_NativeModulesApple.framework/Headers ${PODS_CONFIGURATION_BUILD_DIR}/React-graphics/React_graphics.framework/Headers ${PODS_CONFIGURATION_BUILD_DIR}/React-graphics/React_graphics.framework/Headers/react/renderer/graphics/platform/ios"
            assert_equal(expected_search_path, received_search_path)
        end

        installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
            if pod_name == "SecondTarget"
                target_installation_result.native_target.build_configurations.each do |config|
                    received_search_path = config.build_settings["HEADER_SEARCH_PATHS"]
-                    expected_Search_path = "$(inherited) \"$(PODS_ROOT)/RCT-Folly\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/fast_float/include\" \"$(PODS_ROOT)/fmt/include\" \"$(PODS_ROOT)/boost\" \"${PODS_CONFIGURATION_BUILD_DIR}/ReactCodegen/ReactCodegen.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon/ReactCommon.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon/ReactCommon.framework/Headers/react/nativemodule/core\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-RCTFabric/RCTFabric.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers/react/renderer/components/view/platform/cxx\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-FabricImage/React_FabricImage.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Graphics/React_graphics.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Graphics/React_graphics.framework/Headers/react/renderer/graphics/platform/ios\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers/react/renderer/imagemanager/platform/ios\""
+                    expected_Search_path = "$(inherited) \"$(PODS_ROOT)/RCT-Folly\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/fast_float/include\" \"$(PODS_ROOT)/fmt/include\" \"$(PODS_ROOT)/boost\" \"${PODS_CONFIGURATION_BUILD_DIR}/ReactCodegen/ReactCodegen.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon/ReactCommon.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/ReactCommon/ReactCommon.framework/Headers/react/nativemodule/core\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-runtimeexecutor/React_runtimeexecutor.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-runtimeexecutor/React_runtimeexecutor.framework/Headers/platform/ios\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-RCTFabric/RCTFabric.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers/react/renderer/components/view/platform/cxx\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-FabricImage/React_FabricImage.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Graphics/React_graphics.framework/Headers\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Graphics/React_graphics.framework/Headers/react/renderer/graphics/platform/ios\" \"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers/react/renderer/imagemanager/platform/ios\""


These have apparently changed, too.

artus9033 · 2025-09-24T16:49:43Z

packages/react-native/scripts/cocoapods/utils.rb

        installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
            if pod_name.to_s == target_pod_name
                target_installation_result.native_target.build_configurations.each do |config|
-                        if configuration_type == nil || (configuration_type != nil && config.type == configuration_type)


In this file, indentation was messed up

artus9033 · 2025-09-24T22:15:09Z

packages/react-native/scripts/cocoapods/__tests__/codegen_utils-test.rb

        # Assert
-        assert_equal(DirMock.exist_invocation_params, [codegen_path, codegen_path])
-        assert_equal(DirMock.glob_invocation, ["#{codegen_path}/*", "#{codegen_path}/*"])
+        assert_equal(DirMock.exist_invocation_params, [codegen_path])


This is related to most (although, not all) assert_equal invocations in Ruby tests: the order of arguments is inverted, i.e., expected is swapped with actual. The signature is assert_equal(exp, act, msg = nil), while here and in all other places, the first argument is the actual value and the second is the expected value.

This deteriorates DX since makes it misleading to browse the messages of failed assertions:

artus9033 added 12 commits September 18, 2025 22:25

fix(test): fix integration tests js app problems due to ES exports

354432e

fix(test): fix unit tests compilation errors

b8a93db

fix(test): fix AccessibilityManagerTest failing because of handling l…

3908718

…ifecycle-originating updates from DeviceEventEmitter

test: disable AccessibilityManagerTest due to T225745315

80289f8

docs: update unit and integration tests instructions

7c8e4a9

test: enable RCTLoggingTests

3a0dcd9

chore: update Podfile

c9d42b2

fix(test): mock dispatch_async in RCTBlobManagerTests

a41e886

fix(test): use color constants for RCTConvert_UIColorTests::testGener…

970228c

…ateFallbacks

fix(test): update baseline strings in RCTBundleURLProviderTests

d9db57d

fix(test): use default xctestplan environment variable values in test…

cd572ab

…s, do not attach debugger to tests by default

fix(test): do not skip RCTBundleURLProviderTests in unit tests

30a93fc

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2025

artus9033 added 4 commits September 20, 2025 13:23

Merge branch 'main' into fix/rntester-tests

b34c885

fix: typechecking in IntegrationTestsApp.js

4c51544

chore: update Podfile.lock

462b28b

chore: re-enable debugger in RNTester unit and integration tests

c9484f1

artus9033 force-pushed the fix/rntester-tests branch from 9e9630c to c9484f1 Compare September 20, 2025 15:40

chore: update Podfile

efe4c5c

artus9033 changed the title ~~fix(test): fix RNTester iOS unit and instrumentation tests~~ fix(test): fix RNTester iOS unit and integration tests Sep 21, 2025

artus9033 marked this pull request as ready for review September 21, 2025 10:39

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 21, 2025

cipolleschi requested changes Sep 22, 2025

View reviewed changes

packages/rn-tester/Podfile.lock Outdated Show resolved Hide resolved

packages/rn-tester/IntegrationTests/PromiseTest.js Outdated Show resolved Hide resolved

artus9033 added 6 commits September 23, 2025 11:43

chore: revert changes to Podfile.lock

640e672

fix: use ES exports in IntegrationTests sources, properly destructure…

a400089

… the default export in IntegrationTestsApp

ci: run iOS unit & integration tests on CI

a1ae130

fix(test): fix codegen_utils-test.rb using removed mock helper Codege…

9888b70

…nUtils.set_react_codegen_podspec_generated

fix(test): bad indentation in ruby tests

dc24ea8

fix(test): ruby test - updated baselines in codegen_utils-test

a8f6150

artus9033 added 5 commits September 24, 2025 18:21

fix(test): ruby test - updated baselines in jsengine-test

c627b3e

fix: missing requires in new_architecture.rb

d753226

fix(test): ruby test - updated baselines in new_architecture-test

63ae020

fix(test): ruby test - updated baselines in utils-test

f92b135

refactor: comment in codegen_utils-test.rb

42eb4c3

artus9033 commented Sep 24, 2025

View reviewed changes

artus9033 requested a review from cipolleschi September 24, 2025 16:51

artus9033 added 3 commits September 24, 2025 19:02

Merge branch 'main' into fix/rntester-tests

075bf29

Merge branch 'main' into fix/rntester-tests

fa18880

fix(test): fix order of arguments passed to assert_equal in Ruby tests

5182a1b

artus9033 commented Sep 24, 2025

View reviewed changes

artus9033 added 3 commits September 25, 2025 00:20

fix(ci): bump up the target device of iOS test runner to a present one

c02cc35

Merge branch 'main' into fix/rntester-tests

85138c0

chore: temporarily disable throwIfOnLegacyArch in RCTBridge

d3cb26c

artus9033 force-pushed the fix/rntester-tests branch 2 times, most recently from e54a3d9 to b37ee40 Compare September 28, 2025 21:36

artus9033 added 2 commits September 29, 2025 03:24

wip: attempt to debug failing CI

22cd9a3

Merge branch 'main' into fix/rntester-tests

fe3d3de

artus9033 force-pushed the fix/rntester-tests branch from b37ee40 to fe3d3de Compare September 29, 2025 01:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(test): fix RNTester iOS unit and integration tests #53848

fix(test): fix RNTester iOS unit and integration tests #53848

artus9033 commented Sep 18, 2025 •

edited

Loading

Uh oh!

cipolleschi left a comment

Uh oh!

Uh oh!

Uh oh!

artus9033 commented Sep 23, 2025

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

artus9033 Sep 24, 2025 •

edited

Loading

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

artus9033 Sep 24, 2025

Uh oh!

Uh oh!

		folly_config = Helpers::Constants.folly_config
		folly_compiler_flags = folly_config[:compiler_flags]

fix(test): fix RNTester iOS unit and integration tests #53848

Are you sure you want to change the base?

fix(test): fix RNTester iOS unit and integration tests #53848

Conversation

artus9033 commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

cipolleschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

artus9033 commented Sep 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artus9033 Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

artus9033 commented Sep 18, 2025 •

edited

Loading

artus9033 Sep 24, 2025 •

edited

Loading