adjust java code example for updating your Application (#4387) #4397
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| + try { | ||
| + SoLoader.init(this, OpenSourceMergedSoMapping.INSTANCE); | ||
| + } catch (IOException e) { | ||
| + throw new RuntimeException(e); | ||
| + } |
There was a problem hiding this comment.
Because facebook/react-native#47633 (comment) in my experience it did not work without it.
There was a problem hiding this comment.
Yeah but the IOException catch is not necessary
There was a problem hiding this comment.
I agree since I catch and just rethrow it, so it is useless but without it the build fails:
error: unreported exception IOException; must be caught or declared to be thrown
SoLoader.init(this, OpenSourceMergedSoMapping.INSTANCE);
There was a problem hiding this comment.
I see. That's a bug inside SoLoader and we should fix it rather than having to tweak the documentation
There was a problem hiding this comment.
Summary: This mimics the same behavior of `init(Context, boolean)` and lifts the requirement for Java consumers to catch an exception explicitely. See facebook/react-native-website#4397 Differential Revision: D67032849
…k#135) Summary: This mimics the same behavior of `init(Context, boolean)` and lifts the requirement for Java consumers to catch an exception explicitely. See facebook/react-native-website#4397 Reviewed By: cipolleschi Differential Revision: D67032849
Summary: Pull Request resolved: #135 This mimics the same behavior of `init(Context, boolean)` and lifts the requirement for Java consumers to catch an exception explicitely. See facebook/react-native-website#4397 Reviewed By: cipolleschi, Abbondanzo Differential Revision: D67032849 fbshipit-source-id: 2128e6762f33c52df6f60e2c57a0963bbda5beea
remove try catch since this has now been fixed inside SoLoader
|
We would need for the SoLoader release though |
No description provided.