Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][Codegen] Add docs for advanced iOS usage #4388

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

cipolleschi
Copy link
Contributor

Update docs for Codegen for 0.76 and 0.77

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 111f6d2
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/67617d788125a30008e0f4e9
😎 Deploy Preview https://deploy-preview-4388--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cipolleschi cipolleschi requested a review from cortinico December 5, 2024 20:46
Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cipolleschi - thanks for adding these docs. Such a cool feature of codegen.

I left a couple of typo fix suggestions for you, and I have one general suggestion. I learned about this field through this PR into react-native-cameraroll: https://github.com/react-native-cameraroll/react-native-cameraroll/pull/632/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R122-R126

If you wanted to add examples of why or how to use these fields, I feel like that PR made a lot of sense to me (enable handling certain file handles that RCTImageURLLoader had dropped support for due to the lean core initiative.

Either way, I appreciate your time on this one. :)

@cipolleschi cipolleschi force-pushed the cipolleschi/improve-codegen-docs branch from 76205a4 to 56404db Compare December 9, 2024 11:12
Co-authored-by: Oskar Kwaśniewski <[email protected]>
@cipolleschi cipolleschi merged commit 3125a70 into main Dec 17, 2024
4 checks passed
@cipolleschi cipolleschi deleted the cipolleschi/improve-codegen-docs branch December 17, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants