-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RN][Codegen] Add docs for advanced iOS usage #4388
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cipolleschi - thanks for adding these docs. Such a cool feature of codegen.
I left a couple of typo fix suggestions for you, and I have one general suggestion. I learned about this field through this PR into react-native-cameraroll: https://github.com/react-native-cameraroll/react-native-cameraroll/pull/632/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R122-R126
If you wanted to add examples of why or how to use these fields, I feel like that PR made a lot of sense to me (enable handling certain file handles that RCTImageURLLoader
had dropped support for due to the lean core initiative.
Either way, I appreciate your time on this one. :)
website/versioned_docs/version-0.76/the-new-architecture/using-codegen.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-0.76/the-new-architecture/using-codegen.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-0.76/the-new-architecture/using-codegen.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-0.76/the-new-architecture/using-codegen.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-0.76/the-new-architecture/using-codegen.md
Outdated
Show resolved
Hide resolved
76205a4
to
56404db
Compare
Co-authored-by: Oskar Kwaśniewski <[email protected]>
Update docs for Codegen for 0.76 and 0.77