Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance .gitignore files for better exclusion of unnecessary files #4383

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Dec 3, 2024

Update .gitignore to include additional logs, editor files, and generated artifacts, improving project cleanliness and reducing clutter in version control.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 6e205a4
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/676030487f213d000840a2a9
😎 Deploy Preview https://deploy-preview-4383--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I would prefer us to stay with manually managed .gitignore, and only add entries in there if any issue arose.

Would be nice if you can chop down the changeset down to only necessary changes that would be great.

.gitignore Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
website/.gitignore Outdated Show resolved Hide resolved
@hichemfantar hichemfantar requested a review from Simek December 4, 2024 10:17
.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Bartosz Kaszubowski <[email protected]>
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the gitignore list, LGTM! 👍

@Simek Simek merged commit 99b60d0 into facebook:main Dec 16, 2024
4 checks passed
@hichemfantar hichemfantar deleted the better-gitignore branch December 16, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants